From: Steffen Klassert <steffen.klassert@secunet.com>
To: Fan Du <fan.du@windriver.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCHv3 net-next 2/5] {IPv4,xfrm} Add ESN support for AH ingress part
Date: Tue, 14 Jan 2014 10:54:25 +0100 [thread overview]
Message-ID: <20140114095425.GH31491@secunet.com> (raw)
In-Reply-To: <1389663552-29638-3-git-send-email-fan.du@windriver.com>
On Tue, Jan 14, 2014 at 09:39:09AM +0800, Fan Du wrote:
> @@ -381,7 +393,14 @@ static int ah_input(struct xfrm_state *x, struct sk_buff *skb)
> sg_init_table(sg, nfrags);
> skb_to_sgvec(skb, sg, 0, skb->len);
>
> - ahash_request_set_crypt(req, sg, icv, skb->len);
> + if (x->props.flags & XFRM_STATE_ESN) {
> + sg_unmark_end(&sg[nfrags - 1]);
> + /* Attach seqhi sg right after packet payload */
> + *seqhi = htonl(XFRM_SKB_CB(skb)->seq.output.hi);
This is ah_input(), so you should use the high bits of the input
sequence number here. The ipv6 patch has the same problem.
> + sg_init_table(seqhisg, sglists);
Why do you add a separate SG table for this?
next prev parent reply other threads:[~2014-01-14 9:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 1:39 [PATCHv3 net-next 0/5] xfrm: Add ESN support for AH Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 1/5] {IPv4,xfrm} Add ESN support for AH egress part Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 2/5] {IPv4,xfrm} Add ESN support for AH ingress part Fan Du
2014-01-14 9:54 ` Steffen Klassert [this message]
2014-01-14 10:01 ` Fan Du
2014-01-14 10:09 ` Steffen Klassert
2014-01-14 10:17 ` Fan Du
2014-01-14 10:34 ` Steffen Klassert
2014-01-14 10:41 ` Fan Du
2014-01-14 10:51 ` Steffen Klassert
2014-01-15 7:12 ` Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 3/5] {IPv6,xfrm} Add ESN support for AH egress part Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 4/5] {IPv6,xfrm} Add ESN support for AH ingress part Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 5/5] xfrm: Don't prohibit AH from using ESN feature Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114095425.GH31491@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.