From: Peter Zijlstra <peterz@infradead.org>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Hedi Berriche <hedi@sgi.com>, Russ Anderson <rja@sgi.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems
Date: Tue, 14 Jan 2014 14:39:45 +0100 [thread overview]
Message-ID: <20140114133945.GA7572@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52D53B52.1030201@sgi.com>
On Tue, Jan 14, 2014 at 05:27:46AM -0800, Mike Travis wrote:
>
>
> On 1/14/2014 3:00 AM, Peter Zijlstra wrote:
> > On Mon, Jan 13, 2014 at 10:24:09PM -0600, Mike Travis wrote:
> >> Fix some problems found by the kbuild test robot.
> >>
> >> Signed-off-by: Mike Travis <travis@sgi.com>
> >> Reviewed-by: Hedi Berriche <hedi@sgi.com>
> >
> > In general it is best to actually mention the issues the patch cures,
> > otherwise review is impossible, /me stares hard at Hedi.
> >
>
> I can send an updated patch if required? The issues were
> pretty trivial so I didn't think more info than the patch
> itself was needed.
It makes it impossible to say if what you did corresponds with what you
meant to do; let alone say if its the 'correct' way.
> Hopefully I don't get a lot more in the future (this was my
> first time), should I include the actual tipbot messages?
Sure.
next prev parent reply other threads:[~2014-01-14 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 4:24 [PATCH 0/3] : KGDB/KDB/UV updates Mike Travis
2014-01-14 4:24 ` [PATCH 1/3] PATCH: KGDB/KDB Fix no KDB config problem Mike Travis
2014-01-14 4:24 ` [PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems Mike Travis
2014-01-14 11:00 ` Peter Zijlstra
2014-01-14 13:27 ` Mike Travis
2014-01-14 13:39 ` Peter Zijlstra [this message]
2014-01-14 4:24 ` [PATCH 3/3] PATCH: UV/NMI/KGDB/KDB Fix UV NMI handler when KDB not configed Mike Travis
-- strict thread matches above, loose matches on Subject: below --
2013-10-18 18:53 [PATCH 0/3] : KGDB/KDB/UV updates Mike Travis
2013-10-18 18:53 ` [PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114133945.GA7572@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=hedi@sgi.com \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rja@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.