From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout4.w2.samsung.com ([211.189.100.14]:57170 "EHLO usmailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbaANQHV (ORCPT ); Tue, 14 Jan 2014 11:07:21 -0500 Received: from uscpsbgm2.samsung.com (u115.gpu85.samsung.co.kr [203.254.195.115]) by usmailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZE006ETFG77020@usmailout4.samsung.com> for linux-media@vger.kernel.org; Tue, 14 Jan 2014 11:07:20 -0500 (EST) Date: Tue, 14 Jan 2014 14:07:15 -0200 From: Mauro Carvalho Chehab To: Georgi Chorbadzhiyski Cc: linux-media@vger.kernel.org Subject: Re: FE_READ_SNR and FE_READ_SIGNAL_STRENGTH docs Message-id: <20140114140715.5ed126ac@samsung.com> In-reply-to: <52D55DE7.4050309@unixsol.org> References: <52D554BA.3070906@unixsol.org> <20140114133044.1d5276f4@samsung.com> <52D55DE7.4050309@unixsol.org> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Tue, 14 Jan 2014 17:55:19 +0200 Georgi Chorbadzhiyski escreveu: > Around 01/14/2014 05:30 PM, Mauro Carvalho Chehab scribbled: > > Em Tue, 14 Jan 2014 17:16:10 +0200 > > Georgi Chorbadzhiyski escreveu: > > > >> Hi guys, I'm confused the documentation on: > >> > >> http://linuxtv.org/downloads/v4l-dvb-apis/frontend_fcalls.html#FE_READ_SNR > >> http://linuxtv.org/downloads/v4l-dvb-apis/frontend_fcalls.html#FE_READ_SIGNAL_STRENGTH > >> > >> states that these ioctls return int16_t values but frontend.h states: > >> > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/dvb/frontend.h > >> > >> #define FE_READ_SIGNAL_STRENGTH _IOR('o', 71, __u16) > >> #define FE_READ_SNR _IOR('o', 72, __u16) > >> > >> So which one is true? > > > > Documentation is wrong. The returned values are unsigned. Would you mind send > > us a patch fixing it? > > I would be happy to, but I can't find the repo that holds the documentation. It is in the Kernel tree, under Documentation/DocBook/media/dvb. > > > Btw, the better is to use the new statistics API, when it is > > available: > > http://linuxtv.org/downloads/v4l-dvb-apis/FE_GET_SET_PROPERTY.html#frontend-stat-properties > > > > As it properly specifies the scale of each value. > > When it's ready, I'll add support for the API in dvblast. Good. -- Cheers, Mauro