From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 1/5] crypto: Fully restore ahash request before completing Date: Tue, 14 Jan 2014 18:34:54 +0100 Message-ID: <201401141834.54942.marex@denx.de> References: <1386703583-8386-1-git-send-email-marex@denx.de> <201401051633.21894.marex@denx.de> <20140105232926.GA29518@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-arm-kernel@lists.infradead.org, "David S. Miller" , Fabio Estevam , Shawn Guo , linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:49830 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbaANRez (ORCPT ); Tue, 14 Jan 2014 12:34:55 -0500 In-Reply-To: <20140105232926.GA29518@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Monday, January 06, 2014 at 12:29:27 AM, Herbert Xu wrote: > On Sun, Jan 05, 2014 at 04:33:21PM +0100, Marek Vasut wrote: > > On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote: > > > On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > > > > When finishing the ahash request, the ahash_op_unaligned_done() will > > > > call complete() on the request. Yet, this will not call the correct > > > > complete callback. The correct complete callback was previously > > > > stored in the requests' private data, as seen in > > > > ahash_op_unaligned(). This patch restores the correct complete > > > > callback and .data field of the request before calling complete() on > > > > it. > > > > > > > > Signed-off-by: Marek Vasut > > > > Cc: Herbert Xu > > > > Cc: David S. Miller > > > > Cc: Fabio Estevam > > > > Cc: Shawn Guo > > > > Cc: linux-crypto@vger.kernel.org > > > > > > All patches applied. Thanks! > > > > Uh, I think this was not intended to happen! We still discuss this patch > > will need rework, do we not? > > Please send your new fixes as incremental patches on top of this. I sent a new set of patches and added a bit of documentation too. I am still working on a better piece of documentation for writing crypto drivers now. Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Tue, 14 Jan 2014 18:34:54 +0100 Subject: [PATCH 1/5] crypto: Fully restore ahash request before completing In-Reply-To: <20140105232926.GA29518@gondor.apana.org.au> References: <1386703583-8386-1-git-send-email-marex@denx.de> <201401051633.21894.marex@denx.de> <20140105232926.GA29518@gondor.apana.org.au> Message-ID: <201401141834.54942.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday, January 06, 2014 at 12:29:27 AM, Herbert Xu wrote: > On Sun, Jan 05, 2014 at 04:33:21PM +0100, Marek Vasut wrote: > > On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote: > > > On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > > > > When finishing the ahash request, the ahash_op_unaligned_done() will > > > > call complete() on the request. Yet, this will not call the correct > > > > complete callback. The correct complete callback was previously > > > > stored in the requests' private data, as seen in > > > > ahash_op_unaligned(). This patch restores the correct complete > > > > callback and .data field of the request before calling complete() on > > > > it. > > > > > > > > Signed-off-by: Marek Vasut > > > > Cc: Herbert Xu > > > > Cc: David S. Miller > > > > Cc: Fabio Estevam > > > > Cc: Shawn Guo > > > > Cc: linux-crypto at vger.kernel.org > > > > > > All patches applied. Thanks! > > > > Uh, I think this was not intended to happen! We still discuss this patch > > will need rework, do we not? > > Please send your new fixes as incremental patches on top of this. I sent a new set of patches and added a bit of documentation too. I am still working on a better piece of documentation for writing crypto drivers now. Best regards, Marek Vasut