From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [RFC PATCH v4 2/2] add support for Hyper-V partition reference
 time enlightenment
Date: Tue, 14 Jan 2014 17:10:33 -0200
Message-ID: <20140114191033.GA4898@amt.cnet>
References: <1389691337-12050-1-git-send-email-vrozenfe@redhat.com>
 <1389691337-12050-3-git-send-email-vrozenfe@redhat.com>
 <52D5197C.6090207@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Vadim Rozenfeld <vrozenfe@redhat.com>, kvm@vger.kernel.org,
	pl@dlhnet.de
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:26205 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750928AbaANX5b (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 14 Jan 2014 18:57:31 -0500
Content-Disposition: inline
In-Reply-To: <52D5197C.6090207@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jan 14, 2014 at 12:03:24PM +0100, Paolo Bonzini wrote:
> The cleanup between v3 and v4 is really nice; thanks.  What happened to
> the glitch you reported in the v3 thread.
> 
> Il 14/01/2014 10:22, Vadim Rozenfeld ha scritto:
> > +			tsc_ref.tsc_scale = ((10000LL << 32) /
> > +					     vcpu->arch.virtual_tsc_khz) << 32;
> 
> As mentioned in the review of v3, I don't really like the tsc_scale to
> come from two different sources in the two cases of MSR write and
> KVM_SET_CLOCK.  This is the only qualm I still have with this patch.
> Marcelo, do you have any ideas?

It should be at kvm_guest_time_update.