From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915/bdw: remove preliminary_hw_support flag from BDW Date: Tue, 14 Jan 2014 14:05:45 -0800 Message-ID: <20140114220545.GA7382@bwidawsk.net> References: <1389726256-1625-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BF241065E6 for ; Tue, 14 Jan 2014 14:05:55 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389726256-1625-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 14, 2014 at 11:04:16AM -0800, Jesse Barnes wrote: > It ought to work ok in 3.14. We have some fun stuff coming after that, > but all the basics are in place now and seem relatively stable. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/i915_drv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 61fb9fc..df4d350 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -342,7 +342,6 @@ static const struct intel_device_info intel_haswell_m_info = { > }; > > static const struct intel_device_info intel_broadwell_d_info = { > - .is_preliminary = 1, > .gen = 8, .num_pipes = 3, > .need_gfx_hws = 1, .has_hotplug = 1, > .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING, > @@ -351,7 +350,6 @@ static const struct intel_device_info intel_broadwell_d_info = { > }; > > static const struct intel_device_info intel_broadwell_m_info = { > - .is_preliminary = 1, > .gen = 8, .is_mobile = 1, .num_pipes = 3, > .need_gfx_hws = 1, .has_hotplug = 1, > .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING, I had been hoping to at least get the following in or checked out before marking as not preliminary: semaphores - patch series has one regression, but I would have liked it merged and turned off RC6 well tested - I am not sure what the state of our HW is in this regard. I was told the HW we have doesn't support it, but I haven't tried. RPS - see RC6 4G GGTT - I guess this is currently blocked on PPGTT, which is unfortunate. I can live without this for non-preilm. I've been trying my best to keep the bug count low, and it has been pretty good thanks to you and Paulo - so I think it should be safe enough to call the HW supported, even with my gripes above. So while I prefer to get the stuff above in/tested, if you want to move ahead with this, it's Acked by: Ben Widawsky -- Ben Widawsky, Intel Open Source Technology Center