All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Mamedov <rm@romanrm.net>
To: Chris Murphy <lists@colorremedies.com>
Cc: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: How does btrfs handle bad blocks in raid1?
Date: Wed, 15 Jan 2014 03:54:25 +0600	[thread overview]
Message-ID: <20140115035425.7395087f@natsu> (raw)
In-Reply-To: <6F3D91C0-8CCA-4713-BFEC-244E3D65F306@colorremedies.com>

[-- Attachment #1: Type: text/plain, Size: 2105 bytes --]

On Tue, 14 Jan 2014 14:37:46 -0700
Chris Murphy <lists@colorremedies.com> wrote:

> Reserve sectors are fundamental to ECC. If there are no more reserves, the
> status should be a failed drive, it can no longer do its own relocation of
> data experiencing transient read errors in this case.

With the Reallocated sector count being low in that case, I assume the drive
*had* a lot of reserve space, but due to a buggy firmware didn't "see the need
to use it" just yet for this particular sector.

It's not the question of what is "fundamental" or right, I am describing
observed behavior in the real world - and yes, of course, that behavior is
incorrect and probably an indication of a buggy peculiar firmware.

> I'm considering persistent write failure as a result of no more reserve
> sectors being available.

Write doesn't fail, it succeeds, but you still can't read back the bad block.
And the "reallocated sector count" does not increase.

> Well, not totally useless, if it flags the user with an hour's notice in Gnome,

If we're again talking the user GUI-level indicators, then an increase in
"Reallocated sector count", "Current pending sectors" or "Reported
uncorrectable" should also be a reason for such GUI notice to appear. And
AFAIK that's how smartd howto/manual recommends configuring it (i.e. an E-Mail
on any change in those critical attributes).

> >> a way to send a command to the firmware to persistently increase the reserve
> >> sectors at the expensive of available space - in effect it reduces the LBA
> >> count by e.g. 10MB, thereby increasing the reserve pool by 10MB.
> > 
> > Yes please that, and also a pony. :)
> 
> That seems a lot easier to implement than anything else being discussed. 

Oh really? Pushing that feature into multiple competing vendor's HDD firmwares
across diverse models, product lines, interfaces and revisions is *easier* than
mainlining a patch into the Linux kernel?... My point was that this would have
been a good feature, but no chance we're going to see it realized.

-- 
With respect,
Roman

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2014-01-14 21:54 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201401100106.s0A16CNd016476@atl4mhib27.myregisteredsite.com>
2014-01-10  1:31 ` How does btrfs handle bad blocks in raid1? George Mitchell
2014-01-14 19:13   ` Chris Murphy
2014-01-14 19:37     ` Roman Mamedov
2014-01-14 21:05       ` Chris Murphy
2014-01-14 21:19         ` Roman Mamedov
2014-01-14 21:37           ` Chris Murphy
2014-01-14 21:45             ` Chris Murphy
2014-01-14 21:54             ` Roman Mamedov [this message]
2014-01-14 20:29     ` George Mitchell
2014-01-14 21:00       ` Roman Mamedov
2014-01-14 21:06         ` Hugo Mills
2014-01-14 21:27           ` Chris Murphy
2014-01-14 21:27         ` George Mitchell
2014-01-14 21:28         ` George Mitchell
2014-01-14 21:14       ` Chris Murphy
2014-01-14 21:48         ` George Mitchell
2014-01-14 21:48         ` George Mitchell
2014-01-14 22:14         ` George Mitchell
2014-01-09 10:26 Clemens Eisserer
2014-01-09 10:42 ` Hugo Mills
2014-01-09 12:41   ` Duncan
2014-01-09 12:52     ` Austin S Hemmelgarn
2014-01-09 15:15       ` Duncan
2014-01-09 16:49         ` George Eleftheriou
2014-01-09 17:09           ` Hugo Mills
2014-01-09 17:34             ` George Eleftheriou
2014-01-09 17:43               ` Hugo Mills
2014-01-09 18:40                 ` George Eleftheriou
2014-01-09 17:29           ` Chris Murphy
2014-01-09 18:00             ` George Eleftheriou
2014-01-10 15:27           ` Duncan
2014-01-10 15:46             ` George Mitchell
2014-01-09 17:31       ` Chris Murphy
2014-01-09 18:20         ` Austin S Hemmelgarn
2014-01-09 14:58     ` Chris Mason
2014-01-09 18:08     ` Chris Murphy
2014-01-09 18:22       ` Austin S Hemmelgarn
2014-01-09 18:52         ` Chris Murphy
2014-01-10 17:03           ` Duncan
2014-01-09 18:40   ` Chris Murphy
2014-01-09 19:13     ` Kyle Gates
2014-01-09 19:31       ` Chris Murphy
2014-01-09 23:24         ` George Mitchell
2014-01-10  0:08           ` Clemens Eisserer
2014-01-10  0:46             ` George Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115035425.7395087f@natsu \
    --to=rm@romanrm.net \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.