Re: [PATCH for-next 14/14] IB/mlx5: Remove old field for create mkey mailbox

[Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On Tue, Jan 14, 2014 at 05:37:17PM +0100, Yann Droneaud wrote:
> 
> Is it subject to change between various firmware revision ?
> 
> If yes, it could of user interest to specify the base/current
> version of the applicable firmware.

The sizes never changed and this field was never used so I just
redefined it as reserved.
> 
> > @@ -849,8 +849,8 @@ struct mlx5_create_mkey_mbox_in {
> >  	struct mlx5_mkey_seg	seg;
> >  	u8			rsvd1[16];
> >  	__be32			xlat_oct_act_size;
> > -	__be32			bsf_coto_act_size;
> > -	u8			rsvd2[168];
> > +	__be32			rsvd2;
> 
> For a reserved field, I think we don't care of it being be or le.
> 
Right, so be is just as good as le. The "be" is a sort of reminder
that driver/firmware interface is always big endian.

> > +	u8			rsvd3[168];
> >  	__be64			pas[0];
> >  };
> > 


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html