From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnftables] meta: Let user specify any combination of sreg/dreg
Date: Wed, 15 Jan 2014 11:35:16 +0100 [thread overview]
Message-ID: <20140115103516.GA9911@localhost> (raw)
In-Reply-To: <1389445397-26132-1-git-send-email-kristian.evensen@gmail.com>
On Sat, Jan 11, 2014 at 02:03:17PM +0100, Kristian Evensen wrote:
> From: Kristian Evensen <kristian.evensen@gmail.com>
>
> libnftables should not mask kernel errors. Let user specify any combination of
> parameters and leave the error-checking to the kernel. The kernel will return
> -EINVAL and users will know that they have to fix their code. This patch also a
> removes a redundant variable that was passed to the snprintf-functions (flag).
>
> A second iteration might be needed. I was not sure how to deal with
> snprintf_default in the case of both sreg and dreg.
Applied, thanks Kristian.
prev parent reply other threads:[~2014-01-15 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 13:03 [PATCH libnftables] meta: Let user specify any combination of sreg/dreg Kristian Evensen
2014-01-15 10:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115103516.GA9911@localhost \
--to=pablo@netfilter.org \
--cc=kristian.evensen@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.