From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.186]:57932 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbaAOJ6U (ORCPT ); Wed, 15 Jan 2014 04:58:20 -0500 From: Arnd Bergmann To: Tanmay Inamdar Subject: Re: [RFC PATCH V2 3/4] dt-bindings: pci: xgene pcie device tree bindings Date: Wed, 15 Jan 2014 10:57:42 +0100 Cc: Bjorn Helgaas , Jason Gunthorpe , Grant Likely , Rob Herring , Catalin Marinas , Rob Landley , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, patches@apm.com, jcm@redhat.com References: <1389742458-7693-1-git-send-email-tinamdar@apm.com> <1389742458-7693-4-git-send-email-tinamdar@apm.com> In-Reply-To: <1389742458-7693-4-git-send-email-tinamdar@apm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201401151057.43044.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wednesday 15 January 2014, Tanmay Inamdar wrote: > This patch adds the bindings for X-Gene PCIe driver. The driver resides > under 'drivers/pci/host/pci-xgene.c' file. > > Signed-off-by: Tanmay Inamdar > --- > .../devicetree/bindings/pci/xgene-pcie.txt | 45 ++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/xgene-pcie.txt > > diff --git a/Documentation/devicetree/bindings/pci/xgene-pcie.txt b/Documentation/devicetree/bindings/pci/xgene-pcie.txt > new file mode 100644 > index 0000000..19b9c28 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/xgene-pcie.txt > @@ -0,0 +1,45 @@ > +* AppliedMicro X-Gene PCIe interface > + > +Required properties: > +- status: Either "ok" or "disabled". "status" isn't normally a required property. The default interpretation is that a node without a status property is active. > +- device_type: set to "pci" > +- compatible: should contain "xgene,pcie" to identify the core. > +- reg: base addresses and lengths of the pcie controller configuration > + space register. Doesn't match the code or example: You only list one area here, but you actually need to register sets. Looks good otherwise now. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 15 Jan 2014 10:57:42 +0100 Subject: [RFC PATCH V2 3/4] dt-bindings: pci: xgene pcie device tree bindings In-Reply-To: <1389742458-7693-4-git-send-email-tinamdar@apm.com> References: <1389742458-7693-1-git-send-email-tinamdar@apm.com> <1389742458-7693-4-git-send-email-tinamdar@apm.com> Message-ID: <201401151057.43044.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 15 January 2014, Tanmay Inamdar wrote: > This patch adds the bindings for X-Gene PCIe driver. The driver resides > under 'drivers/pci/host/pci-xgene.c' file. > > Signed-off-by: Tanmay Inamdar > --- > .../devicetree/bindings/pci/xgene-pcie.txt | 45 ++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/xgene-pcie.txt > > diff --git a/Documentation/devicetree/bindings/pci/xgene-pcie.txt b/Documentation/devicetree/bindings/pci/xgene-pcie.txt > new file mode 100644 > index 0000000..19b9c28 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/xgene-pcie.txt > @@ -0,0 +1,45 @@ > +* AppliedMicro X-Gene PCIe interface > + > +Required properties: > +- status: Either "ok" or "disabled". "status" isn't normally a required property. The default interpretation is that a node without a status property is active. > +- device_type: set to "pci" > +- compatible: should contain "xgene,pcie" to identify the core. > +- reg: base addresses and lengths of the pcie controller configuration > + space register. Doesn't match the code or example: You only list one area here, but you actually need to register sets. Looks good otherwise now. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC PATCH V2 3/4] dt-bindings: pci: xgene pcie device tree bindings Date: Wed, 15 Jan 2014 10:57:42 +0100 Message-ID: <201401151057.43044.arnd@arndb.de> References: <1389742458-7693-1-git-send-email-tinamdar@apm.com> <1389742458-7693-4-git-send-email-tinamdar@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389742458-7693-4-git-send-email-tinamdar@apm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tanmay Inamdar Cc: devicetree@vger.kernel.org, jcm@redhat.com, linux-doc@vger.kernel.org, Catalin Marinas , patches@apm.com, linux-kernel@vger.kernel.org, Jason Gunthorpe , Grant Likely , Rob Herring , Rob Landley , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wednesday 15 January 2014, Tanmay Inamdar wrote: > This patch adds the bindings for X-Gene PCIe driver. The driver resides > under 'drivers/pci/host/pci-xgene.c' file. > > Signed-off-by: Tanmay Inamdar > --- > .../devicetree/bindings/pci/xgene-pcie.txt | 45 ++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/xgene-pcie.txt > > diff --git a/Documentation/devicetree/bindings/pci/xgene-pcie.txt b/Documentation/devicetree/bindings/pci/xgene-pcie.txt > new file mode 100644 > index 0000000..19b9c28 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/xgene-pcie.txt > @@ -0,0 +1,45 @@ > +* AppliedMicro X-Gene PCIe interface > + > +Required properties: > +- status: Either "ok" or "disabled". "status" isn't normally a required property. The default interpretation is that a node without a status property is active. > +- device_type: set to "pci" > +- compatible: should contain "xgene,pcie" to identify the core. > +- reg: base addresses and lengths of the pcie controller configuration > + space register. Doesn't match the code or example: You only list one area here, but you actually need to register sets. Looks good otherwise now. Arnd