Re: [Qemu-devel] [PATCH v1 1/2] tests: Add libqemustub to qom-interface-check

[Igor Mammedov <imammedo@redhat.com>]

On Wed, 15 Jan 2014 03:05:36 -0800
Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:

> The recent addition of util/error.c's dependency on error_report()
> causes this test to fail to link due to a number of missing monitor
> related symbols. All these symbols are however defined by libqemustub.
> Add this libary to the link.
> 
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> 
>  tests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 0aaf657..fd36eee 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -151,7 +151,7 @@ tests/check-qdict$(EXESUF): tests/check-qdict.o libqemuutil.a
>  tests/check-qlist$(EXESUF): tests/check-qlist.o libqemuutil.a
>  tests/check-qfloat$(EXESUF): tests/check-qfloat.o libqemuutil.a
>  tests/check-qjson$(EXESUF): tests/check-qjson.o libqemuutil.a libqemustub.a
> -tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(qom-core-obj) libqemuutil.a
> +tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(qom-core-obj) libqemuutil.a libqemustub.a
>  tests/test-coroutine$(EXESUF): tests/test-coroutine.o $(block-obj-y) libqemuutil.a libqemustub.a
>  tests/test-aio$(EXESUF): tests/test-aio.o $(block-obj-y) libqemuutil.a libqemustub.a
>  tests/test-throttle$(EXESUF): tests/test-throttle.o $(block-obj-y) libqemuutil.a libqemustub.a
> -- 
> 1.8.5.3
> 

Reviewed-By: Igor Mammedov <imammedo@redhat.com>

-- 
Regards,
  Igor