Re: [PATCH nft] segtree: add new segtree debugging option

[Patrick McHardy <kaber@trash.net>]

On Wed, Jan 15, 2014 at 01:25:04PM +0100, Pablo Neira Ayuso wrote:
> Currently, nft displays the debugging information if it's compiled with
> --enable-debug (which seems a good idea) and when intervals are used
> in maps. Add a new option to enable debugging to segtree, so we only
> get this information when explicitly requested.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> We need this in master to avoid inconditional display of the
> debugging information when --enable-debug is passed at configuration
> / compilation time. I'm aware this patch conflicts with next-3.14,
> that conflict should be easy to resolve.

Looks good, thanks, I wanted to change this myself.

A few more things about debugging, some are easy, some might be a bit more
work:

- we should use stdout for netlink rule debugging

- netlink rule debugging is very very verbose since it dumps the entire
  netlink message. I'd prefer to only have the netlink expressions
  ([meta load ...]) and have the netlink message as another option.
  It keeps scrolling everything off the screen.

- netlink message debugging colors break in less. We should check for
  isatty().