From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@infradead.org, namhyung@kernel.org, mingo@kernel.org,
dsahern@gmail.com, fweisbec@gmail.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/6] perf, tools: Add --branch-history option to report v2
Date: Wed, 15 Jan 2014 16:42:16 +0100 [thread overview]
Message-ID: <20140115154216.GD17358@krava.redhat.com> (raw)
In-Reply-To: <20140115152344.GO20765@two.firstfloor.org>
On Wed, Jan 15, 2014 at 04:23:44PM +0100, Andi Kleen wrote:
> > this sort of settings needs to be in for the previous patch,
> > to make the following command work:
> >
> > $ perf report --call-graph=fractal,0.5,callee,function,branch
> >
> > will just set symbol_conf.use_callchain, but the sorting stays
> > as SORT_MODE__BRANCH.. and callchains are invisible
>
> You can use --no-branch-stack
that works.. w/o srcline
>
> > as you said in the changelog, this should be 'short cut to make this nicer to use',
> > but it's actually currently the only way..
>
> It works, it's just very long and cumbersome.
well I'd like to see it anyway.. wouldn't need to figure out
it by looking to the code
and the example could be in the next patch then,
it's misleading to reference non existing option
jirka
next prev parent reply other threads:[~2014-01-15 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 1:04 Implement lbr-as-callgraph v3 Andi Kleen
2014-01-14 1:04 ` [PATCH 1/6] perf, tools: fix BFD detection on opensuse Andi Kleen
2014-01-14 1:04 ` [PATCH 2/6] perf, tools: Support handling complete branch stacks as histograms v3 Andi Kleen
2014-01-15 14:48 ` Jiri Olsa
2014-01-15 15:27 ` Andi Kleen
2014-01-15 15:45 ` Jiri Olsa
2014-01-15 15:00 ` Jiri Olsa
2014-01-14 1:04 ` [PATCH 3/6] perf, tools: Add --branch-history option to report v2 Andi Kleen
2014-01-15 14:44 ` Jiri Olsa
2014-01-15 15:23 ` Andi Kleen
2014-01-15 15:42 ` Jiri Olsa [this message]
2014-01-14 1:04 ` [PATCH 4/6] perf, tools: Enable printing the srcline in the history Andi Kleen
2014-01-15 15:12 ` Jiri Olsa
2014-01-14 1:04 ` [PATCH 5/6] perf, tools: Only print base source file for srcline Andi Kleen
2014-01-14 1:04 ` [PATCH 6/6] perf, tools: Support source line numbers in annotate Andi Kleen
2014-01-15 13:59 ` Implement lbr-as-callgraph v3 Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115154216.GD17358@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.