From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [libnftables PATCH] tests: xml: delete comments
Date: Wed, 15 Jan 2014 17:43:39 +0100 [thread overview]
Message-ID: <20140115164339.GA32508@localhost> (raw)
In-Reply-To: <CAOkSjBjTZv0jHzPG6MPYVQU=amvGntwq1qe8FY47O704mFs5fA@mail.gmail.com>
On Wed, Jan 15, 2014 at 05:00:20PM +0100, Arturo Borrero Gonzalez wrote:
> On 15 January 2014 14:12, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Wed, Jan 15, 2014 at 12:12:18PM +0100, Arturo Borrero Gonzalez wrote:
> >> In libmxml > 2.6, comments are not ignored when building the XML tree,
> >> so these comments produce errors and test fail.
> >
> > Doesn't have libmxml any way to accept comments?
>
> I explained it bad, i'm sorry.
>
> When building a XML tree, only one root node can be in place. This is
> a "feature" added in libmxml 2.7:
>
> <<<
> mxmlLoad... did not error out on XML with multiple root nodes (Bug #403)
> >>>
>
> In libmxml 2.6 the second root node was ingored, not because it was a
> comment but because a bug.
> Our files had two root nodes, being comments or not.
> libmxml accept comments, but inside the root node.
That makes sense, I have applied the patch and included this
description. Thanks.
prev parent reply other threads:[~2014-01-15 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 11:12 [libnftables PATCH] tests: xml: delete comments Arturo Borrero Gonzalez
2014-01-15 13:12 ` Pablo Neira Ayuso
2014-01-15 16:00 ` Arturo Borrero Gonzalez
2014-01-15 16:43 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115164339.GA32508@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.