All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf probe: Build error with missing libraries
Date: Wed, 15 Jan 2014 15:38:56 -0300	[thread overview]
Message-ID: <20140115183856.GD9750@ghostprotocols.net> (raw)
In-Reply-To: <87sisq9fa5.fsf@sejong.aot.lge.com>

Em Wed, Jan 15, 2014 at 10:58:58AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
> 
> On Tue, 14 Jan 2014 10:09:07 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 14, 2014 at 10:41:37AM +0900, Masami Hiramatsu escreveu:
> >> (2014/01/14 3:14), Arnaldo Carvalho de Melo wrote:
> >> > Jiri, this is something else for the give-me-more-ponies list for
> >> > tests/make: build it on freshly provisioned systems with multiple mixes
> >> > of devel packages installed ;-)
> >  
> >> I think we can change makefile to get some combinations of config options
> >> when building perf tools.
> >
> > This is what:
> >
> >  make -C tools/perf -f tests/make
> >
> > does, and we use it already, many config combos are tested, but that
> > kinda expects that all optional devel libs be installed.
> 
> I've been thinking that the above should look like below.
> 
>   make build-test (-C tools/perf)
> 
> 
> Maybe something like this?

Haven't tested, but I think it is worth to make this a shortcut, care to
test (if not yet) and resubmit with proper S-O-B, etc?

- Arnaldo
 
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index eefb9fb0c02f..e110c2a2ade1 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -75,6 +75,12 @@ clean:
>  	$(make)
>  
>  #
> +# The build-test target is not really parallel, don't print the jobs info:
> +#
> +build-test:
> +	@$(MAKE) -f tests/make --no-print-directory
> +
> +#
>  # All other targets get passed through:
>  #
>  %:
> 
> -- 
> Thanks,
> Namhyung

  reply	other threads:[~2014-01-15 18:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 18:04 perf probe: Build error with missing libraries Arnaldo Carvalho de Melo
2014-01-13 18:14 ` Arnaldo Carvalho de Melo
2014-01-14  1:41   ` Masami Hiramatsu
2014-01-14 13:09     ` Arnaldo Carvalho de Melo
2014-01-14 13:15       ` Jiri Olsa
2014-01-14 14:21         ` Arnaldo Carvalho de Melo
2014-01-15  1:58       ` Namhyung Kim
2014-01-15 18:38         ` Arnaldo Carvalho de Melo [this message]
2014-01-16  1:26           ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115183856.GD9750@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.