From: Ben Widawsky <ben@bwidawsk.net>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file
Date: Wed, 15 Jan 2014 12:04:37 -0800 [thread overview]
Message-ID: <20140115200437.GA1210@bwidawsk.net> (raw)
In-Reply-To: <20140115012200.GA26338@strange.amr.corp.intel.com>
On Wed, Jan 15, 2014 at 01:22:00AM +0000, Damien Lespiau wrote:
> On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote:
> > +#include <linux/debugfs.h>
> > +#include <linux/fs.h>
> > +#include <linux/seq_file.h>
> > +#include <linux/circ_buf.h>
> > +#include <linux/ctype.h>
> > +#if 0
> > +#include <drm/drm_crtc.h>
> > +#include <drm/drmP.h>
> > +#endif
>
> Could remove that #if
>
Thanks, I left that in by accident.
> Last time I remember we talked about a intel_display_test.c where we
> could shove more stuff (Rodrigo's DP CRC maybe). Either that or Daniel
> last suggestion seems fine (definitely intel_ though, has to do with the
> display)
>
> --
> Damien
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-15 20:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 14:14 [PATCH 1/2] drm: share drm_add_fake_info_node Ben Widawsky
2014-01-14 14:14 ` Ben Widawsky
2014-01-14 14:14 ` [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file Ben Widawsky
2014-01-14 23:28 ` Daniel Vetter
2014-01-15 1:22 ` Damien Lespiau
2014-01-15 8:46 ` Daniel Vetter
2014-01-15 20:04 ` Ben Widawsky [this message]
2014-01-14 23:25 ` [Intel-gfx] [PATCH 1/2] drm: share drm_add_fake_info_node Daniel Vetter
2014-01-14 23:25 ` Daniel Vetter
2014-01-14 23:40 ` Russell King - ARM Linux
2014-01-14 23:40 ` Russell King - ARM Linux
2014-01-15 8:39 ` [Intel-gfx] " Daniel Vetter
2014-01-15 8:39 ` Daniel Vetter
2014-01-15 8:45 ` Daniel Vetter
2014-01-15 8:45 ` Daniel Vetter
2014-01-15 20:08 ` [Intel-gfx] " Ben Widawsky
2014-01-15 20:08 ` Ben Widawsky
2014-01-15 23:42 ` [Intel-gfx] " Daniel Vetter
2014-01-15 23:42 ` Daniel Vetter
2014-01-21 19:05 ` Ben Widawsky
2014-01-21 19:05 ` Ben Widawsky
2014-01-21 20:33 ` [PATCH 1/6] drm: Create a debugfs file creation helper Ben Widawsky
2014-01-21 20:33 ` Ben Widawsky
2014-01-21 20:33 ` [PATCH 2/6] drm/armada: Use new drm debugfs file helper Ben Widawsky
2014-01-21 20:33 ` Ben Widawsky
2014-01-21 20:33 ` [PATCH 3/6] drm/radeon: " Ben Widawsky
2014-01-22 10:11 ` Christian König
2014-01-23 3:20 ` Ben Widawsky
2014-01-23 10:57 ` Christian König
2014-01-21 20:33 ` [PATCH 4/6] drm/i915: " Ben Widawsky
2014-01-21 20:33 ` [PATCH 5/6] drm/i915: Move forcewake debugfs setup also Ben Widawsky
2014-01-21 20:33 ` [PATCH 6/6] drm/i915: Move pipecrc debug functions to new file Ben Widawsky
2014-01-21 21:44 ` Damien Lespiau
2014-01-21 21:50 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115200437.GA1210@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.