From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] config: Update envs for trats and trats2 - new entries for new partitions
Date: Wed, 15 Jan 2014 21:32:37 +0100 [thread overview]
Message-ID: <20140115213237.3a29a9bc@jawa> (raw)
In-Reply-To: <20140115161253.GQ20094@book.gsilab.sittig.org>
Hi Gerard,
> On Tue, Jan 14, 2014 at 08:02 +0100, Lukasz Majewski wrote:
> >
> > diff --git a/include/configs/trats.h b/include/configs/trats.h
> > index 6cd15c2..0bdfe86 100644
> > --- a/include/configs/trats.h
> > +++ b/include/configs/trats.h
> > @@ -143,7 +143,10 @@
> > "u-boot mmc 80 400;" \
> > "uImage ext4 0 2;" \
> > "exynos4210-trats.dtb ext4 0 2;" \
> > - ""PARTS_ROOT" part 0 5\0"
> > + ""PARTS_BOOT" part 0 2;" \
> > + ""PARTS_ROOT" part 0 5;" \
> > + ""PARTS_DATA" part 0 6;" \
> > + ""PARTS_UMS" part 0 7\0"
>
> Have recent compilers become stricter about string concatenation?
I'm using ELDK 5.3 toolchain and this code compiles without warnings.
Also I've tested it with Pengutronix's OSELAS 4.8.2 (OSEALS 2013.12).
> ISTR that a space is recommended (which helps human readers as
> well).
Could you be more specific about the missing space?
Also, since we close the release in a few days, I'd like to ask for
pulling this code as it is.
Those are envs related to DFU/THOR, so probably will be changed in a
near future.
>
>
> virtually yours
> Gerhard Sittig
Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140115/e224379b/attachment.pgp>
next prev parent reply other threads:[~2014-01-15 20:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 7:02 [U-Boot] [PATCH 0/3] fix: Trats/Trats2 default envs adjustement for 2014.01 release Lukasz Majewski
2014-01-14 7:02 ` [U-Boot] [PATCH 1/3] config: Update envs for trats and trats2 - new entries for new partitions Lukasz Majewski
2014-01-14 9:57 ` Minkyu Kang
2014-01-15 16:12 ` Gerhard Sittig
2014-01-15 20:32 ` Lukasz Majewski [this message]
2014-01-16 16:10 ` Gerhard Sittig
2014-01-16 22:12 ` Wolfgang Denk
2014-01-17 14:11 ` Gerhard Sittig
2014-01-17 13:05 ` [U-Boot] [U-Boot, " Tom Rini
2014-01-14 7:02 ` [U-Boot] [PATCH 2/3] ARM: trats2: dfu: Enable default Poll Timeout for Trats2 board Lukasz Majewski
2014-01-14 9:57 ` Minkyu Kang
2014-01-17 13:06 ` [U-Boot] [U-Boot, " Tom Rini
2014-01-14 7:02 ` [U-Boot] [PATCH 3/3] config: Update envs for trats and trats2 - Disable L2 cache Lukasz Majewski
2014-01-14 9:57 ` Minkyu Kang
2014-01-17 13:06 ` [U-Boot] [U-Boot, " Tom Rini
2014-01-17 10:34 ` [U-Boot] [PATCH 0/3] fix: Trats/Trats2 default envs adjustement for 2014.01 release Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115213237.3a29a9bc@jawa \
--to=l.majewski@majess.pl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.