All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "x86: fix 27-rc crash on vsmp due to paravirt during module load"
Date: Thu, 16 Jan 2014 09:44:58 +0100	[thread overview]
Message-ID: <20140116084458.GA9346@gmail.com> (raw)
In-Reply-To: <1389838259-29411-1-git-send-email-paul.gortmaker@windriver.com>


* Paul Gortmaker <paul.gortmaker@windriver.com> wrote:

> This reverts commit 05e12e1c4c09cd35ac9f4e6af1e42b0036375d72.
> 
> The old change from __init --> __init_or_module doesn't make
> sense anymore, given that the arch/x86/kernel/vsmp_64.c code
> is only for non-modular builds.
> 
> As of commit 70511134f61bd6e5eed19f767381f9fb3e762d49
> ("Revert "x86: don't compile vsmp_64 for 32bit") this file
> became obj-y and hence is only for built-in.  That makes
> any "or_module" support redundant.
> 
> We need to distinguish between the two in order to do some
> header cleanups.  This revert starts that process.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I suspect you want to carry this as part of your header cleanups, to 
not have to wait for upstream propagation?

Please fix the title: the original commit was right, but was mooted by 
other changes. That's not a revert but a change that happens to be the 
inverse of an earlier change.

Thanks,

	Ingo

       reply	other threads:[~2014-01-16  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1389838259-29411-1-git-send-email-paul.gortmaker@windriver.com>
2014-01-16  8:44 ` Ingo Molnar [this message]
2014-01-16 14:41   ` [PATCH] Revert "x86: fix 27-rc crash on vsmp due to paravirt during module load" Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116084458.GA9346@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.