All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, apw@canonical.com,
	jasowang@redhat.com
Subject: Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
Date: Thu, 16 Jan 2014 10:42:01 +0100	[thread overview]
Message-ID: <20140116094200.GA16328@aepfle.de> (raw)
In-Reply-To: <1389728116-21337-1-git-send-email-kys@microsoft.com>

On Tue, Jan 14, K. Y. Srinivasan wrote:

> +enum hv_fcopy_op {
> +	START_FILE_COPY = 0,
> +	WRITE_TO_FILE,
> +	COMPLETE_FCOPY,
> +	CANCEL_FCOPY,
> +};
> +
> +struct hv_fcopy_hdr {
> +	enum hv_fcopy_op operation;
> +	uuid_le service_id0; /* currently unused */
> +	uuid_le service_id1; /* currently unused */
> +} __attribute__((packed));

Is enum a fixed size? This struct is used in other structs, so I wonder
what will happen to the kernel/user protocol if any of that changes. Or
with a 64bit kernel and 32bit daemon. Maybe operation should be __u32?


Olaf

  parent reply	other threads:[~2014-01-16  9:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 19:35 [PATCH V2 1/1] Drivers: hv: Implement the file copy service K. Y. Srinivasan
2014-01-14 22:13 ` Olaf Hering
2014-01-14 23:12   ` KY Srinivasan
2014-01-15 16:33 ` Olaf Hering
2014-01-15 19:11   ` KY Srinivasan
2014-01-16  9:42 ` Olaf Hering [this message]
2014-01-16 15:52   ` KY Srinivasan
2014-01-17  7:31   ` Dan Carpenter
2014-01-16 10:16 ` Olaf Hering
2014-01-16 15:51   ` KY Srinivasan
2014-01-16 10:48 ` Olaf Hering
2014-01-16 15:50   ` KY Srinivasan
2014-01-20 22:13   ` KY Srinivasan
2014-01-20 22:16     ` Olaf Hering
2014-01-20 22:23       ` KY Srinivasan
2014-01-16 11:26 ` Olaf Hering
2014-01-16 15:49   ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116094200.GA16328@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.