From: Steffen Klassert <steffen.klassert@secunet.com>
To: Fan Du <fan.du@windriver.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCHv4 net-next 3/6] {IPv4,xfrm} Add ESN support for AH ingress part
Date: Thu, 16 Jan 2014 10:56:47 +0100 [thread overview]
Message-ID: <20140116095647.GL31491@secunet.com> (raw)
In-Reply-To: <1389769995-350-4-git-send-email-fan.du@windriver.com>
On Wed, Jan 15, 2014 at 03:13:12PM +0800, Fan Du wrote:
>
> - ahash_request_set_crypt(req, sg, icv, skb->len);
> + if (x->props.flags & XFRM_STATE_ESN) {
> + /* Attach seqhi sg right after packet payload */
> + *seqhi = htonl(XFRM_SKB_CB(skb)->seq.input.hi);
XFRM_SKB_CB(skb)->seq.input.hi is already in network byte order,
please remove the htonl(). The ipv6 patch has the same problem.
next prev parent reply other threads:[~2014-01-16 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 7:13 [PATCHv4 net-next 0/6] xfrm: Add ESN support for AH Fan Du
2014-01-15 7:13 ` [PATCHv4 net-next 1/6] skbuff: Introduce skb_to_sgvec_nomark to map skb without mark new end Fan Du
2014-01-15 7:13 ` [PATCHv4 net-next 2/6] {IPv4,xfrm} Add ESN support for AH egress part Fan Du
2014-01-15 7:13 ` [PATCHv4 net-next 3/6] {IPv4,xfrm} Add ESN support for AH ingress part Fan Du
2014-01-16 9:56 ` Steffen Klassert [this message]
2014-01-15 7:13 ` [PATCHv4 net-next 4/6] {IPv6,xfrm} Add ESN support for AH egress part Fan Du
2014-01-15 7:13 ` [PATCHv4 net-next 5/6] {IPv6,xfrm} Add ESN support for AH ingress part Fan Du
2014-01-15 7:13 ` [PATCHv4 net-next 6/6] xfrm: Don't prohibit AH from using ESN feature Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116095647.GL31491@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.