From: Wolfram Sang <wsa@the-dreams.de>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
broonie@linaro.org, gregkh@linuxfoundation.org,
rafael.j.wysocki@intel.com, grant.likely@linaro.org,
rob.herring@calxeda.com, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com
Subject: Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices
Date: Thu, 16 Jan 2014 13:27:04 +0100 [thread overview]
Message-ID: <20140116122704.GD2617@katana> (raw)
In-Reply-To: <1389689198-2641-4-git-send-email-rui.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index d74c0b3..c4c5588 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -104,6 +104,11 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
> static int i2c_device_uevent(struct device *dev, struct kobj_uevent_env *env)
> {
> struct i2c_client *client = to_i2c_client(dev);
> + int rc;
> +
> + rc = acpi_device_uevent_modalias(dev, env);
> + if (rc != -ENODEV)
> + return rc;
>
> if (add_uevent_var(env, "MODALIAS=%s%s",
> I2C_MODULE_PREFIX, client->name))
I wonder why we don't have/need that with CONFIG_OF? Because probably
nobody is using modules with i2c devices there?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-16 12:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 8:46 [PATCH 0/4] module autoloading fixes Zhang Rui
2014-01-14 8:46 ` Zhang Rui
2014-01-14 8:46 ` [PATCH 1/4] ACPI: fix create_modalias() return value handling Zhang Rui
[not found] ` <1389689198-2641-2-git-send-email-rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-01-15 15:02 ` Mika Westerberg
2014-01-15 15:02 ` Mika Westerberg
2014-01-14 8:46 ` [PATCH 2/4] ACPI: add module autoloading support for ACPI enumerated devices Zhang Rui
[not found] ` <1389689198-2641-1-git-send-email-rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-01-14 8:46 ` [PATCH 3/4] fix module autoloading " Zhang Rui
2014-01-14 8:46 ` Zhang Rui
2014-01-15 15:08 ` Mika Westerberg
[not found] ` <20140115150834.GX2494-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-01-16 8:04 ` Zhang Rui
2014-01-16 8:04 ` Zhang Rui
2014-01-17 1:28 ` Rafael J. Wysocki
2014-01-17 1:28 ` Rafael J. Wysocki
[not found] ` <3559262.qTvGllE4Ix-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-01-17 1:56 ` Zhang Rui
2014-01-17 1:56 ` Zhang Rui
2014-01-16 12:27 ` Wolfram Sang [this message]
2014-01-16 13:05 ` Zhang Rui
2014-01-16 13:05 ` Zhang Rui
2014-01-16 19:46 ` Mark Brown
2014-01-17 7:37 ` Jarkko Nikula
[not found] ` <52D8DDD4.10704-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-01-17 15:57 ` Mark Brown
2014-01-17 15:57 ` Mark Brown
2014-01-20 7:10 ` Jarkko Nikula
[not found] ` <1389689198-2641-4-git-send-email-rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-01-16 12:28 ` Mark Brown
2014-01-16 12:28 ` Mark Brown
[not found] ` <20140116122819.GO15567-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-16 12:51 ` Zhang Rui
2014-01-16 12:51 ` Zhang Rui
2014-01-16 19:24 ` Wolfram Sang
2014-01-16 19:24 ` Wolfram Sang
2014-01-14 8:46 ` [PATCH 4/4] OF: introduce OF style 'modalias' support for platform bus Zhang Rui
2014-01-15 13:45 ` Rob Herring
[not found] ` <CAL_JsqJFRQ+27N_9AwZXpx4V=g8HKn84WdVKtQ_Br_8SQTXY7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-16 1:09 ` Rafael J. Wysocki
2014-01-16 1:09 ` Rafael J. Wysocki
2014-01-16 7:04 ` Zhang, Rui
2014-01-16 21:21 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2014-01-13 13:48 [PATCH 3/4] fix module autoloading for ACPI enumerated devices Zhang Rui
2014-01-13 13:48 ` Zhang Rui
[not found] ` <1389620911-3890-1-git-send-email-rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-01-13 17:35 ` Mark Brown
2014-01-13 17:35 ` Mark Brown
[not found] ` <20140113173525.GF29039-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-14 8:00 ` Zhang Rui
2014-01-14 8:00 ` Zhang Rui
2014-01-14 14:41 ` Mark Brown
2014-01-14 14:41 ` Mark Brown
2014-01-15 1:16 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116122704.GD2617@katana \
--to=wsa@the-dreams.de \
--cc=broonie@linaro.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rob.herring@calxeda.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.