From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/3] AArch64: KGDB support
Date: Thu, 16 Jan 2014 13:45:50 +0000 [thread overview]
Message-ID: <20140116134550.GA7496@arm.com> (raw)
In-Reply-To: <1387453851-19341-1-git-send-email-vijay.kilari@gmail.com>
On Thu, Dec 19, 2013 at 11:50:48AM +0000, vijay.kilari at gmail.com wrote:
> Vijaya Kumar K (3):
> AArch64: KGDB: Add Basic KGDB support
> AArch64: KGDB: Add step debugging support
> KGDB: make kgdb_breakpoint() as noinline
I gave them a try and now I have some doubts about your testing
methodology:
1. There is no HAVE_ARCH_KGDB anywhere in these patches, so
the code here isn't compiled.
2. There are several compiler warnings that need to be addressed.
3. I enabled CONFIG_KGDB_TESTS and CONFIG_KGDB_TESTS_ON_BOOT and that's
what really scared me.
Please address these before we can consider the patches for merging.
--
Catalin
next prev parent reply other threads:[~2014-01-16 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 11:50 [PATCH v6 0/3] AArch64: KGDB support vijay.kilari at gmail.com
2013-12-19 11:50 ` [PATCH v6 1/3] AArch64: KGDB: Add Basic " vijay.kilari at gmail.com
2014-01-16 13:47 ` Catalin Marinas
2013-12-19 11:50 ` [PATCH v6 2/3] AArch64: KGDB: Add step debugging support vijay.kilari at gmail.com
2013-12-19 11:50 ` [PATCH v6 3/3] KGDB: make kgdb_breakpoint() as noinline vijay.kilari at gmail.com
2014-01-15 16:44 ` Jason Wessel
2014-01-15 16:48 ` Will Deacon
2014-01-06 18:12 ` [PATCH v6 0/3] AArch64: KGDB support Will Deacon
2014-01-07 12:11 ` Catalin Marinas
2014-01-15 10:17 ` Vijay Kilari
2014-01-15 23:31 ` Andrew Pinski
2014-01-16 13:45 ` Catalin Marinas [this message]
2014-01-18 8:02 ` Vijay Kilari
2014-01-20 10:23 ` Will Deacon
[not found] ` <CALicx6v-pxOxdx4Q+a_Rx4XdHPXvgbVoYuouJoBxRdENMzCvAA@mail.gmail.com>
[not found] ` <20140121183604.GQ30706@mudshark.cambridge.arm.com>
2014-01-22 4:31 ` Vijay Kilari
2014-01-22 7:50 ` Vijay Kilari
2014-01-22 10:31 ` Will Deacon
2014-01-22 14:54 ` Vijay Kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116134550.GA7496@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.