From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id F2D7FE0085A for ; Thu, 16 Jan 2014 11:25:35 -0800 (PST) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s0GJPXG1024886; Thu, 16 Jan 2014 13:25:33 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s0GJPXCw026065; Thu, 16 Jan 2014 13:25:33 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Thu, 16 Jan 2014 13:25:32 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s0GJPXX6028104; Thu, 16 Jan 2014 13:25:33 -0600 Date: Thu, 16 Jan 2014 14:25:32 -0500 From: Denys Dmytriyenko To: "Maupin, Chase" Message-ID: <20140116192532.GJ12727@edge> References: <1389820588-17906-1-git-send-email-denis@denix.org> <7D46E86EC0A8354091174257B2FED101598FA0D1@DLEE11.ent.ti.com> <20140115223333.GF12727@edge> <7D46E86EC0A8354091174257B2FED101598FCB79@DLEE11.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <7D46E86EC0A8354091174257B2FED101598FCB79@DLEE11.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-ti@yoctoproject.org" , Archit Taneja Subject: Re: [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 19:25:47 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Thu, Jan 16, 2014 at 09:11:37AM -0500, Maupin, Chase wrote: > >-----Original Message----- > >From: Dmytriyenko, Denys > >Sent: Wednesday, January 15, 2014 4:34 PM > >To: Maupin, Chase > >Cc: Denys Dmytriyenko; meta-ti@yoctoproject.org > >Subject: Re: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass > >CROSS_COMPILE > > > >On Wed, Jan 15, 2014 at 10:25:01PM +0000, Maupin, Chase wrote: > >> >-----Original Message----- > >> >From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- > >> >bounces@yoctoproject.org] On Behalf Of Denys Dmytriyenko > >> >Sent: Wednesday, January 15, 2014 3:16 PM > >> >To: meta-ti@yoctoproject.org > >> >Subject: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass > >> >CROSS_COMPILE > >> > > >> >From: Denys Dmytriyenko > >> > > >> >Signed-off-by: Denys Dmytriyenko > >> >--- > >> > recipes-bsp/ti/vpe-vpdma_git.bb | 6 +++--- > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > >> >diff --git a/recipes-bsp/ti/vpe-vpdma_git.bb b/recipes- > >bsp/ti/vpe- > >> >vpdma_git.bb > >> >index d506791..fb3012a 100644 > >> >--- a/recipes-bsp/ti/vpe-vpdma_git.bb > >> >+++ b/recipes-bsp/ti/vpe-vpdma_git.bb > >> >@@ -8,9 +8,9 @@ LIC_FILES_CHKSUM = > >> >"file://COPYING;md5=74d2f71d8898c54e3d1c9d0058c484aa" > >> > COMPATIBLE_MACHINE = "dra7xx-evm" > >> > > >> > PV = "1b8" > >> >-PR = "r0" > >> >+PR = "r1" > >> > > >> >-SRCREV = "24a5487ec13bf560f0e7fb24a9d4747f9f358be2" > >> >+SRCREV = "e3d8db1aa935775f9d196ad7428e0cd9864a36ca" > >> > BRANCH ?= "master" > >> > > >> > SRC_URI = > >> > >>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${B > >R > >> >ANCH}" > >> >@@ -18,7 +18,7 @@ SRC_URI = > >> > >>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${B > >R > >> >ANCH > >> > S = "${WORKDIR}/git" > >> > > >> > # The test application needs additional include headers from > >the > >> >kernel > >> >-EXTRA_OEMAKE = 'KDIR="${STAGING_KERNEL_DIR}/include/uapi - > >> >I${STAGING_KERNEL_DIR}/include"' > >> >+EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}" > >> >KDIR="${STAGING_KERNEL_DIR}/include/uapi - > >> >I${STAGING_KERNEL_DIR}/include"' > >> > >> Shouldn't the setting of CC in OE already take care of this? Or > >did the rebase affect the Makefile? > > > >I believe it has been affected by this commit: > >http://git.ti.com/gitweb/?p=vpe_tests/vpe_tests.git;a=commitdiff;h > >=e3d8db1aa935775f9d196ad7428e0cd9864a36ca > > > >It overrides CC in the Makefile and the simplest way is to pass > >CROSS_COMPILE. > > Ah. The commit I was on used CC ?= .... so you didn't have to pass CROSS_COMPILE. Thanks. So, I'll be pushing this change shortly. Going forward, can we try to avoid rebases - I don't believe it was even necessary here... -- Denys