From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH v2 for-3.14] dm cache: add block sizes and total cache blocks to status output Date: Thu, 16 Jan 2014 14:35:33 -0500 Message-ID: <20140116193533.GA30851@redhat.com> References: <20140109210412.GA5288@redhat.com> <684DDE51-1D4E-44AB-8E85-CDD6F38B5D07@redhat.com> <20140109221323.GA5555@redhat.com> <20140109235506.GA6154@redhat.com> <4DBC7936-62EF-475A-AAFF-B8B6977DD4E8@redhat.com> <20140116043456.GA22229@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Brassow Jonathan Cc: device-mapper development , ejt@redhat.com List-Id: dm-devel.ids On Thu, Jan 16 2014 at 12:18pm -0500, Brassow Jonathan wrote: > > On Jan 15, 2014, at 10:34 PM, Mike Snitzer wrote: > > > On Wed, Jan 15 2014 at 8:16pm -0500, > > Brassow Jonathan wrote: > > > >> I know I'm pushing my luck... > >> > >> Is it too late to ask for just one more thing? Would you also consider printing the policy name in the status (INFO)? > >> <#policy args> > >> > >> This is especially useful when you pass in "default" in the CTR, because you cannot get this value from anywhere... right? > > > > For the benefit of others, I pushed the change here: > > http://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=2f20afc4c3f69030204ce55f24bc68971b500b8a > > This doesn't quite produce the info we want. If I specify "default" > in the CTR table, I want the status to show me what the result was > (i.e. "mq"). It currently seems to be printing "default" back at > me... which isn't helpful. :) I updated the commit, see: http://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=2e68c4e6caad9fdadc1cef8b6cb9569192e8a42b I've also verified it works (by updating my local device-mapper-test-suite code, will get these changes to joe soon)