All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: scdbackup@gmx.net
Subject: Re: grub-shell: Pass -no-pad to xorriso when building floppy images
Date: Thu, 16 Jan 2014 23:13:53 +0400	[thread overview]
Message-ID: <20140116231353.7fbde35a@opensuse.site> (raw)
In-Reply-To: <1413645726316204936@scdbackup.webframe.org>

В Thu, 16 Jan 2014 19:56:16 +0100
"Thomas Schmitt" <scdbackup@gmx.net> пишет:

> Hi,
> 
> > There is no second "--". grub-mkrescue --help tries to say, that
> > everything after "--" is simply passed on to xorriso. What is
> > confusing, is "or any of the mkisofs options" in previous sentence
> > which implies that "--" is not needed.
> 
> It used to work the way which is still in the docs.
> 
> See
>   http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.in?id=2.00
> 
> Its arguments are interpreted by
> 
>   while test $# -gt 0
>   do
>      ...
>      case "$option" in
>      ...
>      *)
> 	  source="${source} ${option} $@"; break ;;
>      esac
>   done
> 
> I.e the unrecognized arguments are added to the list of
> source files which is later submitted to the xorriso -as mkisofs
> emulation:
> 
>   # build iso image
>   "${xorriso}" -as mkisofs ... ${source}
> 
> Among the xorriso arguments, the "--" has the effect that xorriso
> will leave mkisofs emulation and interpret the following arguments
> as its native commands and their parameters.
> 

Ah, right, sorry.

> 
> But the new C code obviously thinks too much when seeing
> single-dash arguments, which it should handle as xorriso arguments.
> And it eats "--". At least if it is the first non-mkrescue argument.
> 
> 
> So:
> 
> What argument interpretation behavior is grub-mkrescue 2.02
> supposed to show ?
> 
> The one that is currently documented and matches grub-mkrescue.in 
> of 2.00 ?
> 
> Or the one that is result of using grub-core/gnulib/argp-parse.c ?

Yes. It is standard behavior where everything after "--" is interpreted
as non-option. You need it to avoid unknown option error from parser.

> The latter would need to be explored and documented, then.
> 

I think it is enough to say that everything after first "--" is passed
onto xorriso. The fact that second "--" will enter native xorriso is
documented in xorriso manual; anyone who would like to make use of this
feature probably knows it.


  reply	other threads:[~2014-01-16 19:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 12:49 [PATCH] grub-shell: Pass -no-pad to xorriso when building floppy images Colin Watson
2014-01-16 14:05 ` Thomas Schmitt
2014-01-16 14:53   ` Colin Watson
2014-01-16 16:17     ` Thomas Schmitt
2014-01-16 16:28       ` Thomas Schmitt
2014-01-16 18:21         ` Andrey Borzenkov
2014-01-16 18:56       ` Thomas Schmitt
2014-01-16 19:13         ` Andrey Borzenkov [this message]
2014-01-16 19:43           ` Thomas Schmitt
2014-01-22 15:12     ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-22 15:36       ` Thomas Schmitt
2014-01-25 16:27       ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116231353.7fbde35a@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    --cc=scdbackup@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.