From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH] ceph: trivial comment fix Date: Thu, 16 Jan 2014 21:01:19 -0500 Message-ID: <20140117020119.GC20521@fieldses.org> References: <20140116224253.GB20521@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fieldses.org ([174.143.236.118]:47476 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751811AbaAQCBU (ORCPT ); Thu, 16 Jan 2014 21:01:20 -0500 Content-Disposition: inline In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Sage Weil Cc: ceph-devel@vger.kernel.org On Thu, Jan 16, 2014 at 04:03:38PM -0800, Sage Weil wrote: > On Thu, 16 Jan 2014, J. Bruce Fields wrote: > > From: "J. Bruce Fields" > > > > "disconnected" is too easily confused with "DCACHE_DISCONNECTED". I > > think "unhashed" is the more precise term here. > > Good point. Applied, thanks! Thanks! While I'm looking, there's another d_find_alias() caller in build_inode_path. What's that? (Do the mds protocol messages actually use full paths?) And will this break if you get a DCACHE_DISCONNECTED or an unhashed alias? --b. > sage > > > > > > Signed-off-by: J. Bruce Fields > > --- > > fs/ceph/caps.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Just ran across this while wondering what d_find_alias callers do.... > > > > diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c > > index 3c0a4bd..697f9d7 100644 > > --- a/fs/ceph/caps.c > > +++ b/fs/ceph/caps.c > > @@ -2350,11 +2350,11 @@ static void invalidate_aliases(struct inode *inode) > > d_prune_aliases(inode); > > /* > > * For non-directory inode, d_find_alias() only returns > > - * connected dentry. After calling d_invalidate(), the > > - * dentry become disconnected. > > + * hashed dentry. After calling d_invalidate(), the > > + * dentry becomes unhashed. > > * > > * For directory inode, d_find_alias() can return > > - * disconnected dentry. But directory inode should have > > + * unhashed dentry. But directory inode should have > > * one alias at most. > > */ > > while ((dn = d_find_alias(inode))) { > > -- > > 1.7.9.5 > > > >