From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Marek Vasut <marex@denx.de>,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-mtd@lists.infradead.org,
Sourav Poddar <sourav.poddar@ti.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
Date: Fri, 17 Jan 2014 10:04:54 +0800 [thread overview]
Message-ID: <20140117020453.GC27652@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20140116210529.GF8919@ld-irv-0074>
On Thu, Jan 16, 2014 at 01:05:29PM -0800, Brian Norris wrote:
> On Thu, Jan 16, 2014 at 01:09:34AM +0100, Marek Vasut wrote:
> > On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> > > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> > >
> > > commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> > > quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> > > 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> > > 3-byte and 4-byte addressing.
> > >
> > > Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
>
> Wow, I noticed this and had a patch privately queued over a month ago
> for this, but I forgot to send it out... Thanks for noticing!
>
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > Looks all right.
> >
> > Acked-by: Marek Vasut <marex@denx.de>
>
> Pushed to l2-mtd.git.
this is a bad news to me. I have to send out a new version for the SPI NOR framework.
could this patch be merged after my spi-nor patch set? or create a new patch based
on the spi-nor framework.
thanks
Huang Shijie
next prev parent reply other threads:[~2014-01-17 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 15:48 [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing Geert Uytterhoeven
2014-01-16 0:09 ` Marek Vasut
2014-01-16 21:05 ` Brian Norris
2014-01-17 2:04 ` Huang Shijie [this message]
2014-01-17 7:01 ` Brian Norris
2014-01-18 21:20 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117020453.GC27652@shlinux2.ap.freescale.net \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.