From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH] spi: Remove duplicate code to set default bits_per_word setting Date: Fri, 17 Jan 2014 13:55:27 +0100 Message-ID: <201401171355.27291.marex@denx.de> References: <1389956020.6412.5.camel@phoenix> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Mark Brown , Matt Porter , Alison Wang , Chao Fu , Yoshihiro Shimoda , Guenter Roeck , Barry Song , Tomoya MORINAGA , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Axel Lin Return-path: In-Reply-To: <1389956020.6412.5.camel@phoenix> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Friday, January 17, 2014 at 11:53:40 AM, Axel Lin wrote: > The implementation in spi_setup() already set spi->bits_per_word = 8 when > spi->bits_per_word is 0 before calling spi->master->setup. > So we don't need to do it again in setup() callback. > > Cc: Matt Porter > Cc: Alison Wang > Cc: Chao Fu > Cc: Marek Vasut > Cc: Yoshihiro Shimoda > Cc: Guenter Roeck > Cc: Barry Song > Cc: Tomoya MORINAGA > Signed-off-by: Axel Lin Good catch, for spi-mxs: Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html