From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 17 Jan 2014 15:43:31 +0100 Subject: [U-Boot] [PATCH 1/3] sf: ops: Squash the malloc+memset combo In-Reply-To: <9e839652-bcb9-45d6-95c5-ebd5b2ec0998@AM1EHSMHS010.ehs.local> References: <9e839652-bcb9-45d6-95c5-ebd5b2ec0998@AM1EHSMHS010.ehs.local> Message-ID: <201401171543.31458.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, January 17, 2014 at 03:41:45 PM, Jagannadha Sutradharudu Teki wrote: > Squash the malloc()+memset() combo in favor of calloc(). > > Signed-off-by: Jagannadha Sutradharudu Teki > Cc: Marek Vasut > --- > drivers/mtd/spi/sf_ops.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c > index 1f1bb36..9650486 100644 > --- a/drivers/mtd/spi/sf_ops.c > +++ b/drivers/mtd/spi/sf_ops.c > @@ -381,8 +381,7 @@ int spi_flash_cmd_read_ops(struct spi_flash *flash, u32 > offset, } > > cmdsz = SPI_FLASH_CMD_LEN + flash->dummy_byte; > - cmd = malloc(cmdsz); > - memset(cmd, 0, cmdsz); > + cmd = calloc(1, cmdsz); > > cmd[0] = flash->read_cmd; What exactly will happen here when calloc() fails ? :-) (that means, please check the return value ;-) ) > while (len) { Best regards, Marek Vasut