From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't disable DP port after a failed link training Date: Fri, 17 Jan 2014 18:13:33 +0100 Message-ID: <20140117171333.GL4770@phenom.ffwll.local> References: <1389890158-30938-2-git-send-email-imre.deak@intel.com> <1389966403-16330-1-git-send-email-imre.deak@intel.com> <20140117135843.GC4196@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id ABA87FA98A for ; Fri, 17 Jan 2014 09:13:37 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id e49so2272437eek.0 for ; Fri, 17 Jan 2014 09:13:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140117135843.GC4196@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jan 17, 2014 at 01:58:43PM +0000, Chris Wilson wrote: > On Fri, Jan 17, 2014 at 03:46:43PM +0200, Imre Deak wrote: > > Atm after a failed link training we disable the DP port. This can happen > > during a modeset-enable or a DP link re-establishment. The latter can be > > a problem and we shouldn't disable the DP port, see the previous patch for > > the reasoning. In the former case the right thing would be to disable > > the DP port, but also the rest of the pipe. > > > > As a stop-gap solution leave the DP port enabled in both cases. It is an > > improvement on its own (avoiding HW lock ups) and the proper solution > > for the first case requires a bigger change, so let's keep that on the > > TODO list. > > > > v2: > > - fix explanation of change impact (Chris) > > > > Suggested-by: Daniel Vetter > > Signed-off-by: Imre Deak > Reviewed-by: Chris Wilson > and r-b for patch 1 as well (if I didn't send it). Both merged, thanks. -Daniel > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch