From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/2] ethdev: Introduce if_index field to struct rte_eth_dev_info Date: Fri, 17 Jan 2014 18:33:02 +0100 Message-ID: <201401171833.02597.thomas.monjalon@6wind.com> References: <1389274977-53532-1-git-send-email-liljegren.mats2@gmail.com> <1389274977-53532-2-git-send-email-liljegren.mats2@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Mats Liljegren Return-path: In-Reply-To: <1389274977-53532-2-git-send-email-liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" what about this title? "ethdev: introduce if_index in device info" > This field is intended for pcap to describe the name of the interface > as known to Linux. It is an interface index, but can be translated into > an interface name using if_indextoname() function. > > When using pcap, interrupt affinity becomes important, and this field > gives the application a chance to ensure that interrupt affinity is set > to the lcore handling the device. > > Signed-off-by: Mats Liljegren > [...] > + unsigned int if_index; /**< Index to bounded host interface, or 0 if > none. Use if_indextoname() to translate into an interface name. */ I'd split this long line like this: + unsigned if_index; /**< Index to bounded host interface, or 0 if none. + Use if_indextoname() to translate into an interface name. */ -- Thomas