All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES
Date: Sat, 18 Jan 2014 21:12:02 +0400	[thread overview]
Message-ID: <20140118211202.20f09930@opensuse.site> (raw)
In-Reply-To: <52DAB20A.106@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

В Sat, 18 Jan 2014 17:55:38 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 18.01.2014 17:27, Andrey Borzenkov wrote:
> >  While on it, pass detected
> > nm arguments instead of hardcoding them.
> please make this part a separate patch.

is it OK to commit without this part?

> This would indicate that you
> support non-portable nm output which in this branch isn't the case. Why
> do you need it in the first place?
> 

I do not need it for MinGW case; but it just looks incorrect in general
case - first we check nm arguments and then ignore it. I agree that
mixing two patches was wrong on my side.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2014-01-18 17:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 16:27 [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES Andrey Borzenkov
2014-01-18 16:55 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-18 17:12   ` Andrey Borzenkov [this message]
2014-01-18 18:08     ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-18 18:36       ` Andrey Borzenkov
2014-01-18 19:05         ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140118211202.20f09930@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.