All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: eiichiro.oiwa.nm@hitachi.com
Cc: bhelgaas@google.com, linux@eikelenboom.it, airlied@redhat.com,
	gregkh@linuxfoundation.org, konrad.wilk@oracle.com,
	linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
	airlied@linux.ie
Subject: Re: In "pci_fixup_video" check if this is or should be theprimaryvideo d
Date: Sun, 19 Jan 2014 12:44:10 +0200	[thread overview]
Message-ID: <20140119104410.GB4195@redhat.com> (raw)
In-Reply-To: <XNM1$9$0$4$$3$3$7$A$9006873U52d90952@hitachi.com>

On Fri, Jan 17, 2014 at 07:43:30PM +0900, eiichiro.oiwa.nm@hitachi.com wrote:
> Because legacy VGA is only one device on x86 System, I think qemu has to emulate a bridge
> for legacy VGA. The VGA Enable bit on its bridge control register has to set to 1. The VGA
> Enable bit describes in Table 3-10 Bridge Control register. When there are two VGA cards 
> on the same system, I think its system needs two bridges for each device. These bridges
> need bridge control registers. One VGA Enable bit on its bridge for legacy VGA has to set
> to 1. Another VGA Enable bit for second VGA has to set to 0.
> 
> 
> >On Thu, Jan 16, 2014 at 7:16 PM,  <eiichiro.oiwa.nm@hitachi.com> wrote:
> >> I think qemu is breaking "PCI-to-PCI Bridge Architecture Specification Revison 1.2
> >> June 9, 2003 Chapter 12. VGA Support".
> >
> >And what exactly do you think qemu is doing wrong?  Chapter 12 is ten
> >pages long.  Is there something there that prohibits two VGA devices
> >on the same bus?  I'm not a qemu developer, but if I were, I would
> >need a better hint about what is wrong before I could fix it.
> >
> >Again, sorry if you said this already and I missed it.
> >
> >>>[+cc Michael, Jesse, David, qemu-devel]
> >>>
> >>>On Wed, Jan 15, 2014 at 8:58 PM,  <eiichiro.oiwa.nm@hitachi.com> wrote:
> >>>> I suggest you should not break the PCI specification, as a developer of proprietary
> >>>> hypervisor, but I think your patch is no problem.
> >>>> Your PCI structure is specialized structure for your virtual machine.
> >>>> Maybe, your virtual machine will be causing another problem on Linux or other kernels
> >>>> because of breaking the PCI specification.
> >>>
> >>>I assume you think qemu is breaking the PCI spec.  What exactly do you
> >>>think is broken?  Please give specific references to the spec.  This
> >>>conversation is pretty fragmented, and I came in late, so I apologize
> >>>if I missed this.
> >>>
> >>>Bjorn
> >>>
> >

None of the bridges included in QEMU implements VGA support.
The spec explicitly says its optional, so that's ok.

As a result, you need to put device which has to work in
VGA mode on the root bus, any device behind a bridge
won't work in VGA mode (but might work in non VGA mode).

-- 
MST

  parent reply	other threads:[~2014-01-19 10:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <XNM1$9$0$4$$3$3$7$A$9006870U52d8928d@hitachi.com>
2014-01-17  4:13 ` In "pci_fixup_video" check if this is or should be the primaryvideo d Bjorn Helgaas
     [not found] ` <CAErSpo678TwmMu7tB5u2uWogLCvQPyoZeXz3Do52XUTSGjYAwg@mail.gmail.c>
     [not found]   ` <XNM1$9$0$4$$3$3$7$A$9006873U52d90952@hitachi.com>
2014-01-17 15:39     ` Re[2]: In "pci_fixup_video" check if this is or should be theprimaryvideo d Bjorn Helgaas
2014-01-17 16:14       ` Bjorn Helgaas
2014-01-19 10:39       ` Michael S. Tsirkin
2014-01-19 10:44     ` Michael S. Tsirkin [this message]
2014-01-19 14:04       ` Alex Williamson
2014-01-19 15:09         ` Michael S. Tsirkin
2014-01-19 15:14           ` Sander Eikelenboom
2014-01-19 18:27             ` Michael S. Tsirkin
2014-01-19 19:05               ` Sander Eikelenboom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140119104410.GB4195@redhat.com \
    --to=mst@redhat.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=eiichiro.oiwa.nm@hitachi.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.