Re: [PATCH 1/3] drm/i915: get basic encoder state before reading CRTC state

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Sat, 18 Jan 2014 16:01:06 +0200
Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:

> On Fri, Jan 17, 2014 at 01:16:56PM -0800, Jesse Barnes wrote:
> > In DDI configs, we need to get the encoder to CRTC mapping early on so
> > we can read out and calculate the clock state correctly, as it depends
> > on the port.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 59 +++++++++++++++++++++++++++---------
> >  1 file changed, 44 insertions(+), 15 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 74137d5..92f46ad 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -9476,6 +9476,22 @@ check_crtc_state(struct drm_device *dev)
> >  		     "crtc's computed enabled state doesn't match tracked enabled state "
> >  		     "(expected %i, found %i)\n", enabled, crtc->base.enabled);
> >  
> > +
> > +		list_for_each_entry(encoder, &dev->mode_config.encoder_list,
> > +				    base.head) {
> > +			/* Get encoder->crtc mapping */
> > +			struct intel_crtc *tmp_crtc;
> > +			enum pipe pipe;
> > +			if (encoder->get_hw_state(encoder, &pipe)) {
> > +				tmp_crtc = to_intel_crtc(dev_priv->pipe_to_crtc_mapping[pipe]);
> > +				if (tmp_crtc == crtc) {
> > +					encoder->base.crtc = &tmp_crtc->base;
> > +					encoder->get_config(encoder,
> > +							    &pipe_config);
> > +				}
> > +			}
> > +		}
> > +
> >  		active = dev_priv->display.get_pipe_config(crtc,
> >  							   &pipe_config);
> >  
> 
> NAK. This will break clock readout for every other platform. For most 
> things we read out the .port_clock from the DPLL in .get_pipe_config()
> (eDP port A being the excption where intel_dp_get_config() also fills
> out .port_clock), and then the encoder .get_config() massages .port_clock
> appropriately to figure out what .crtc_clock was supposed to be.
> 
> Maybe I'm missing something, but can't you just follow the eDP port A
> route and simply stick your intel_ddi_clock_get() into
> intel_ddi_get_config(), so that intel_ddi_get_config() is always
> responsible for filling out both .port_clock and .crtc_clock?
> 

Yeah I knew this would cause trouble.  I might be able to get the clock
later, but I just need to make sure the CRTC to encoder mapping is set
up when I need it.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx