All of lore.kernel.org
 help / color / mirror / Atom feed
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dma: imx-sdma: clarify firmare not found warning
Date: Mon, 20 Jan 2014 12:28:40 +0100	[thread overview]
Message-ID: <20140120122840.36520f37@ipc1.ka-ro> (raw)
In-Reply-To: <1390212438-6855-1-git-send-email-s.hauer@pengutronix.de>

Hi,

Sascha Hauer wrote:
> When a firmware cannot be found for the SDMA engine then we can
> continue with the inernal ROM firmware.
> 
> The meaning of this message is frequently asked for, so make clear
> that the driver still works with the internal ROM firmware and reduce
> the loglevel from err to info.
> 
In case user space firmware loading 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Shawn Guo <shawn.guo@linaro.org>
> ---
> 
> changes since v1:
> - instead of removing the message make it more clear
> 
>  drivers/dma/imx-sdma.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c75679d..d79eaad 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1259,7 +1259,10 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
>  	unsigned short *ram_code;
>  
>  	if (!fw) {
> -		dev_err(sdma->dev, "firmware not found\n");
> +		dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
> +		/*
> +		 * In this case we just use the ROM firmware.
> +		 */
>  		return;
>  	}
>  


-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

  reply	other threads:[~2014-01-20 11:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 10:07 [PATCH v2] dma: imx-sdma: clarify firmare not found warning Sascha Hauer
2014-01-20 11:28 ` Lothar Waßmann [this message]
2014-01-20 11:36   ` Lothar Waßmann
2014-01-20 12:38     ` Russell King - ARM Linux
2014-01-20 11:59       ` Vinod Koul
2014-01-20 13:09         ` Sascha Hauer
2014-01-20 14:09       ` Lothar Waßmann
2014-01-20 15:11         ` Russell King - ARM Linux
2014-01-21  6:59           ` Lothar Waßmann
2014-01-21 11:01             ` Russell King - ARM Linux
2014-01-21 11:52               ` Lothar Waßmann
2014-01-21 11:57                 ` Russell King - ARM Linux
2014-01-21 13:36                   ` Lothar Waßmann
2014-01-21 14:10                     ` Russell King - ARM Linux
2014-01-21  7:06     ` Sascha Hauer
2014-01-21  8:31       ` Lothar Waßmann
2014-10-25 12:28 ` Fabio Estevam
2014-11-12 11:13   ` Vinod Koul
2014-11-12 22:05     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140120122840.36520f37@ipc1.ka-ro \
    --to=lw@karo-electronics.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.