Re: [PATCH] drm/i915: Shuffle modeset reset handling around

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Jan 17, 2014 at 06:14:50PM -0200, Paulo Zanoni wrote:
> 2014/1/16 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Currently we're doing the reset handling a bit late, and we're doing
> > it both in the driver load code and on resume. This makes it unusable
> > for e.g. resetting the panel power sequence state like Paulo wants to.
> >
> > Instead of adding yet another single-use callback shuffle things
> > around:
> > - Output handling code is responsible to reset/init all state on its
> >   own at driver load time.
> > - We call the reset functions much earlier, before we start using any
> >   of the modeset code.
> >
> > Compared to Paulo's new ->resume callback the only difference in
> > placement is that ->reset is still called without dev->struct_mutex
> > held. Which is imo a feature.
> >
> > v2: Rebase on top of the now merge dinq.
> >
> > Cc: Paulo Zanoni <przanoni@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Yeah, now I can use it on the eDP patch.
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch