From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core
Date: Mon, 20 Jan 2014 18:33:19 +0000 [thread overview]
Message-ID: <20140120183319.GX17314@sirena.org.uk> (raw)
In-Reply-To: <1390231125.11756.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Mon, Jan 20, 2014 at 11:18:45PM +0800, Axel Lin wrote:
> The checking for spi->mode is done in the implementation of spi_setup().
> Calling sc18is602_check_transfer(spi, NULL, 0) is pointless because
> the code is equivent to checking if spi->max_speed_hz is 0.
> Note, sc18is602_check_transfer actually allows spi->max_speed_hz is 0
> if t->speed_hz is set. So return error in sc18is602_setup() when
> spi->max_speed_hz is 0 does not make sense.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-01-20 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 15:18 [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core Axel Lin
2014-01-20 16:24 ` Guenter Roeck
2014-01-20 18:33 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120183319.GX17314@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.