From: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 1/3] add a new option "testonly"
Date: Mon, 20 Jan 2014 13:51:08 -0500 [thread overview]
Message-ID: <20140120185108.GD11319@redhat.com> (raw)
In-Reply-To: <20140120022848.GA18942-je1gSBvt1TeLcxizHhUEZR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On Mon, Jan 20, 2014 at 10:28:48AM +0800, Baoquan He wrote:
[..]
> > I personally feel it should be watchdog module but if harald does not
> > like it, we can atleast for the time being keep that logic in kdump
> > module. But trying to create this testonly mode feels odd to me.
>
> Yeah, agree. For the time being, only iTCO_wdt need load module and
> satisfacory. However, there are many kinds of watchdog with different
> implementation. Finally, a independent dracut module may be needed, it
> can be put into dracut as a independent folder, e.g 06wdt which is
> different then 04watchdog.
I think creating another watchdog module 06wdt does not make much sense.
Eiter this logic needs to be merged into existing watchdog module 04wdt
or we modify kdump module to load watchdog drivers in kdump initramfs
as a short term approach till we can convince harald that keeping this
logic in 04watchdog is a good idea.
Thanks
Vivek
prev parent reply other threads:[~2014-01-20 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 12:53 [PATCH 1/3] add a new option "testonly" Baoquan He
[not found] ` <1389790430-17808-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-15 12:53 ` [PATCH 2/3] set testonly for the relevant test cases Baoquan He
2014-01-15 12:53 ` [PATCH 3/3] insert wdt kernel modules when watchdog is active Baoquan He
2014-01-15 20:16 ` [PATCH 1/3] add a new option "testonly" Vivek Goyal
[not found] ` <20140115201608.GA13541-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-16 2:06 ` Dave Young
[not found] ` <20140116020647.GD3807-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-16 2:12 ` Dave Young
2014-01-20 2:28 ` Baoquan He
[not found] ` <20140120022848.GA18942-je1gSBvt1TeLcxizHhUEZR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-20 18:51 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120185108.GD11319@redhat.com \
--to=vgoyal-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.