From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/2] add support for building the server
Date: Mon, 20 Jan 2014 22:44:28 +0100 [thread overview]
Message-ID: <20140120214428.GE3421@free.fr> (raw)
In-Reply-To: <1390172539-5207-2-git-send-email-kuyurix@gmail.com>
Marcelo, All,
On 2014-01-19 23:02 +0000, Marcelo Guti?rrez spake thusly:
> From: "Marcelo Guti?rrez(UTN/FRH)" <kuyurix@gmail.com>
This one looks actually good to me! :-)
One minor nit, though:
This changelog:
> Changes v2 -> v3:
> - rename field <number> in the patch file name
> - update new options postion
> - update description to Makefile
> - update Config.in
>
> Changes v1 -> v2:
> - fix comments following new policy
> - rename patches
> - remove useless hook points
> - add the URL to the home of MySQL
> - add commit-log description to the patches
> - install host tools to $(HOST_DIR)/usr/bin
> - fix only builds the required program
should go...
> Signed-off-by: Marcelo Guti?rrez(UTN/FRH) <kuyurix@gmail.com>
> ---
Here, after the three-dash-line. git interprets this three-dash-line as
a marker for the end of the commit log, so it will not appear in the
history, since we don;t really need it.
(Ditto for your patch 1/2, too.)
Otherwise, looks good to me! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-01-20 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 23:02 [Buildroot] [PATCH 1/2] Rename MySQL client package Marcelo Gutiérrez
2014-01-19 23:02 ` [Buildroot] [PATCH v3 2/2] add support for building the server Marcelo Gutiérrez
2014-01-20 21:44 ` Yann E. MORIN [this message]
2014-01-20 21:33 ` [Buildroot] [PATCH 1/2] Rename MySQL client package Yann E. MORIN
2014-01-20 21:45 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120214428.GE3421@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.