From: Dave Jones <davej@redhat.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: trinity@vger.kernel.org
Subject: Re: cppcheck mentions format string error
Date: Mon, 20 Jan 2014 17:00:49 -0500 [thread overview]
Message-ID: <20140120220049.GA2792@redhat.com> (raw)
In-Reply-To: <52CDA849.2080203@gmx.de>
On Wed, Jan 08, 2014 at 08:34:33PM +0100, Toralf Förster wrote:
> On 01/08/2014 08:04 PM, Dave Jones wrote:
> > On Wed, Jan 08, 2014 at 07:52:02PM +0100, Toralf Förster wrote:
> >> heise.de reported about a security flaw in xorg-server found by
> >> cppcheck - so I just gave it a try.
> >>
> >> It reports :
> >>
> >> ~/devel/trinity $ cppcheck ./ --force --quiet [devices.c:90]:
> >> (warning) %a in format string (no. 2) requires 'float *' but the
> >> argument type is 'char * *'.
> >>
> >>
> >> Is it correct ?
> >
> > no. Looks like it doesn't understand the gnu %as extension, and
> > thinks it's %a followed by 's'.
> >
> > That extension isn't C99, but given portability isn't really a goal
> > for trinity, I'm not overly bothered by it.
> >
> > Dave
> >
> >
> ok
>
> FWIW I created an enhancement request for cppcheck :
>
> Ticket URL: <http://sourceforge.net/apps/trac/cppcheck/ticket/5329>
I'm not sure why I never noticed before, but after upgrading some packages
this last week, suddenly gcc and llvm are both warning about it.
After filing a bug on what I thought was a gcc bug, Jakub suggested
switching to %ms, which should make things happier, including cppcheck.
strange.
Dave
prev parent reply other threads:[~2014-01-20 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:52 cppcheck mentions format string error Toralf Förster
2014-01-08 19:04 ` Dave Jones
2014-01-08 19:34 ` Toralf Förster
2014-01-20 22:00 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120220049.GA2792@redhat.com \
--to=davej@redhat.com \
--cc=toralf.foerster@gmx.de \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.