From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 7/7] drm/gem: dont init "ret" in drm_gem_mmap()
Date: Tue, 21 Jan 2014 10:51:22 +0100
Message-ID: <20140121095122.GQ15089@phenom.ffwll.local>
References: <1390245989-13280-1-git-send-email-dh.herrmann@gmail.com>
	<1390245989-13280-7-git-send-email-dh.herrmann@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com
	[209.85.215.181])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6BEDAFB054
	for <dri-devel@lists.freedesktop.org>;
	Tue, 21 Jan 2014 01:51:28 -0800 (PST)
Received: by mail-ea0-f181.google.com with SMTP id m10so3656002eaj.12
	for <dri-devel@lists.freedesktop.org>;
	Tue, 21 Jan 2014 01:51:26 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1390245989-13280-7-git-send-email-dh.herrmann@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Mon, Jan 20, 2014 at 08:26:29PM +0100, David Herrmann wrote:
> There is no need to initialize this variable, so drop it. Otherwise, the
> compiler won't warn if we use it unintialized.
> 
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>

I've replied with a few small comments on some patches, with those
addressed all but patch 3 are

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

A follow-up to 4 to remove callsites from drivers would be neat though.
-Daniel

> ---
>  drivers/gpu/drm/drm_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 7bf374e..700e8df 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -819,7 +819,7 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
>  	struct drm_device *dev = priv->minor->dev;
>  	struct drm_gem_object *obj;
>  	struct drm_vma_offset_node *node;
> -	int ret = 0;
> +	int ret;
>  
>  	if (drm_device_is_unplugged(dev))
>  		return -ENODEV;
> -- 
> 1.8.5.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch