From: NeilBrown <neilb@suse.de>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: Linux RAID Mailing List <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] Allow to check mdadm with clangs static checker (scan-build)
Date: Tue, 21 Jan 2014 10:06:43 +1100 [thread overview]
Message-ID: <20140121100643.0ebaf13d@notabene.brown> (raw)
In-Reply-To: <52DD4B54.4060809@fastmail.fm>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On Mon, 20 Jan 2014 17:14:12 +0100 Bernd Schubert
<bernd.schubert@fastmail.fm> wrote:
> Clangs scan-build tool (static checker) set the environmental variable CC,
> so Makefile should allow to use that value.
>
> Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 043bcea..63cc3ac 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,7 +41,7 @@ KLIBC=/home/src/klibc/klibc-0.77
>
> KLIBC_GCC = gcc -nostdinc -iwithprefix include -I$(KLIBC)/klibc/include -I$(KLIBC)/linux/include -I$(KLIBC)/klibc/arch/i386/include -I$(KLIBC)/klibc/include/bits32
>
> -CC = $(CROSS_COMPILE)gcc
> +CC ?= $(CROSS_COMPILE)gcc
> CXFLAGS ?= -ggdb
> CWFLAGS = -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter
> ifdef WARN_UNUSED
I'm not exactly against this, but presumably you could tell scan-build to run
make CC=$CC
to achieve the same effect with no patch ??
i.e.
scan-build 'make CC=$CC'
But maybe I'll apply it anyway.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-01-20 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 16:14 [PATCH] Allow to check mdadm with clangs static checker (scan-build) Bernd Schubert
2014-01-20 23:06 ` NeilBrown [this message]
2014-01-21 17:39 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121100643.0ebaf13d@notabene.brown \
--to=neilb@suse.de \
--cc=bernd.schubert@fastmail.fm \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.