Re: [Intel-gfx] [PATCH] drm/i915: quirk invert brightness for Acer Aspire 5336

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: quirk invert brightness for Acer Aspire 5336
Date: Tue, 21 Jan 2014 15:05:24 +0200	[thread overview]
Message-ID: <20140121130524.GC9454@intel.com> (raw)
In-Reply-To: <1389627034-27766-1-git-send-email-jani.nikula@intel.com>

On Mon, Jan 13, 2014 at 05:30:34PM +0200, Jani Nikula wrote:
> Since
> commit ee1452d7458451a7508e0663553ce88d63958157
> Author: Jani Nikula <jani.nikula@intel.com>
> Date:   Fri Sep 20 15:05:30 2013 +0300
> 
>     drm/i915: assume all GM45 Acer laptops use inverted backlight PWM
> 
> failed and was later reverted in
> commit be505f643925e257087247b996cd8ece787c12af
> Author: Alexander van Heukelum <heukelum@fastmail.fm>
> Date:   Sat Dec 28 21:00:39 2013 +0100
> 
>     Revert "drm/i915: assume all GM45 Acer laptops use inverted backlight PWM"
> 
> fix the individual broken machine instead.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=54171
> Reference: http://mid.gmane.org/DUB115-W7628C7C710EA51AA110CD4A5000@phx.gbl
> CC: stable@vger.kernel.org
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> ---
> 
> Daniel, this is on top of -fixes.
> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2bde35d34eb9..8712b5e93d7a 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10556,6 +10556,9 @@ static struct intel_quirk intel_quirks[] = {
>  	/* Acer Aspire 4736Z */
>  	{ 0x2a42, 0x1025, 0x0260, quirk_invert_brightness },
>  
> +	/* Acer Aspire 5336 */
> +	{ 0x2a42, 0x1025, 0x048a, quirk_invert_brightness },
> +
>  	/* Dell XPS13 HD Sandy Bridge */
>  	{ 0x0116, 0x1028, 0x052e, quirk_no_pcm_pwm_enable },
>  	/* Dell XPS13 HD and XPS13 FHD Ivy Bridge */
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC