All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: tvboxspy@gmail.com, gregkh@linuxfoundation.org
Subject: Re: staging: vt6656: device.h Remove typedef enum __device_init_type.
Date: Tue, 21 Jan 2014 10:16:43 -0500	[thread overview]
Message-ID: <20140121151643.GA19358@redhat.com> (raw)
In-Reply-To: <20140121002130.38BFD660F3F@gitolite.kernel.org>

On Tue, Jan 21, 2014 at 12:21:30AM +0000, Linux Kernel wrote:
 > Gitweb:     http://git.kernel.org/linus/;a=commit;h=302433daf47aeb7d21d66e55fb84d6a8fffd4aed
 > Commit:     302433daf47aeb7d21d66e55fb84d6a8fffd4aed
 > Parent:     a72f8beeedc97b776799a1a80c04eb5312980c9b
 > Author:     Malcolm Priestley <tvboxspy@gmail.com>
 > AuthorDate: Sun Nov 3 17:40:51 2013 +0000
 > Committer:  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 > CommitDate: Mon Nov 11 16:31:00 2013 -0800
 > 
 >     staging: vt6656: device.h Remove typedef enum __device_init_type.
 >     
 >     Since typedef enum __device_init_type is only ever called
 >     in one state.
 >     
 >     Remove the typedef from main_usb.c:device_init_registers and
 >     replace with macro values. The other values may be needed later.
 >     
 >     Apply cold value to sInitCmd.byInitClass.
 >     
 >     Remove if braces and correct formatting within.

 ...

 >  	/* load power table */
 >  	for (ii = 0; ii < 14; ii++) {
 > -            pDevice->abyCCKPwrTbl[ii] = pDevice->abyEEPROM[ii + EEP_OFS_CCK_PWR_TBL];
 > -            if (pDevice->abyCCKPwrTbl[ii] == 0)
 > -                pDevice->abyCCKPwrTbl[ii] = pDevice->byCCKPwr;
 > -            pDevice->abyOFDMPwrTbl[ii] = pDevice->abyEEPROM[ii + EEP_OFS_OFDM_PWR_TBL];
 > -            if (pDevice->abyOFDMPwrTbl[ii] == 0)
 > -                pDevice->abyOFDMPwrTbl[ii] = pDevice->byOFDMPwrG;
 > -        }
 > +		pDevice->abyCCKPwrTbl[ii] =
 > +			pDevice->abyEEPROM[ii + EEP_OFS_CCK_PWR_TBL];
 > +
 > +		if (pDevice->abyCCKPwrTbl[ii] == 0)
 > +			pDevice->abyCCKPwrTbl[ii] = pDevice->byCCKPwr;
 > +			pDevice->abyOFDMPwrTbl[ii] =
 > +				pDevice->abyEEPROM[ii + EEP_OFS_OFDM_PWR_TBL];
 > +		if (pDevice->abyOFDMPwrTbl[ii] == 0)
 > +			pDevice->abyOFDMPwrTbl[ii] = pDevice->byOFDMPwrG;
 > +	}

Wrong indentation of the pDevice->abyOFDMPwrTbl[ii] assignment.
Wrapping this to 80 columns has actually made this less readable imo.

	Dave


       reply	other threads:[~2014-01-21 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140121002130.38BFD660F3F@gitolite.kernel.org>
2014-01-21 15:16 ` Dave Jones [this message]
2014-01-22  1:57   ` staging: vt6656: device.h Remove typedef enum __device_init_type Greg KH
2014-01-22  2:01     ` Joe Perches
2014-01-22 19:15       ` Malcolm Priestley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140121151643.GA19358@redhat.com \
    --to=davej@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.