From: Matthew Garrett <mjg59@srcf.ucam.org>
To: alex.hung@canonical.com
Cc: platform-driver-x86@vger.kernel.org
Subject: hp-wmi rfkill change breaks systems
Date: Tue, 21 Jan 2014 15:17:02 +0000 [thread overview]
Message-ID: <20140121151702.GA2566@srcf.ucam.org> (raw)
Hi Alex,
997daa1bd9aca412ab97955a35b26c460c0ec7a4 seems to break some systems
(https://bugzilla.kernel.org/show_bug.cgi?id=69131 for example). The
simplest approach seems to be to simply do something like the following:
@@ -883,8 +883,8 @@ static int __init hp_wmi_bios_setup(struct
platform_device *device)
gps_rfkill = NULL;
rfkill2_count = 0;
- if (hp_wmi_bios_2009_later() || hp_wmi_rfkill_setup(device))
- hp_wmi_rfkill2_setup(device);
+ if (hp_wmi_rfkill2_setup(device))
+ hp_wmi_rfkill_setup(device);
Do you know if there are any cases that would be broken by this?
--
Matthew Garrett | mjg59@srcf.ucam.org
next reply other threads:[~2014-01-21 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 15:17 Matthew Garrett [this message]
2014-01-22 8:29 ` hp-wmi rfkill change breaks systems Alex Hung
2014-01-23 7:25 ` Alex Hung
2015-08-28 3:49 ` Ward, David - 0665 - MITLL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121151702.GA2566@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alex.hung@canonical.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.