Re: [PATCH] Improve DejaVuSans detection

[Andrey Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2226 bytes --]

В Tue, 21 Jan 2014 08:46:41 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> > Prefer DejaVuSansMono if found, on openSUSE DejaVuSans is proportional font.
> > 
> It's fine to use SansMono for terminal (I'd prefer unifont though) but
> this change also changes the way various items in menu are displayed.
> Monospace fonts are less dense so allow less info in menu on small screens.

Yes, I realized that. The problem is, unifont may be missing (user is
free to override it with GRUB_FONT) and theme must be self-consistent
(which is also why my other attempt to set font to Unifont is not quite
correct as well). I tried to build fixed width DejaVuSansMono, but I do
not like results enough. First, it results in extremely large vertical
size using standard parameters; e.g.

bor@opensuse:~/build/grub> ./build-grub-mkfont -o /tmp/foo.pf2 -v -s 12 /usr/share/fonts/truetype/DejaVuSansMono.ttf 
Unknown gsub font feature 0x63636d70 (ccmp)
Unknown gsub font feature 0x646c6967 (dlig)
Unsupported substitution flag: 0x9
Unsupported substitution flag: 0x9
Unknown gsub font feature 0x6c6f636c (locl)
Unknown gsub font feature 0x6c6f636c (locl)
Unsupported substitution flag: 0x9
Font name: DejaVu Sans Mono Regular 12
Max width: 11
Max height: 22
Font ascent: 14
Font descent: 4
Number of glyph: 3388

22 height for font size 12! Forcing hinting gives something more close
to reality

bor@opensuse:~/build/grub> ./build-grub-mkfont -o /tmp/foo.pf2 -v -s 12 -a /usr/share/fonts/truetype/DejaVuSansMono.ttf 
Unknown gsub font feature 0x63636d70 (ccmp)
Unknown gsub font feature 0x646c6967 (dlig)
Unsupported substitution flag: 0x9
Unsupported substitution flag: 0x9
Unknown gsub font feature 0x6c6f636c (locl)
Unknown gsub font feature 0x6c6f636c (locl)
Unsupported substitution flag: 0x9
Font name: DejaVu Sans Mono Regular 12
Max width: 11
Max height: 16
Font ascent: 13
Font descent: 5
Number of glyph: 3388

But still too high so vertical lines look dashed.

May be the simplest solution would be to follow the same logic as
gfxterm - unless terminal-font is explicitly set, use $gfxterm_font by
default with fallback to first loaded font.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]