From: Rob Schroer <sulamiification@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hid/wacom: fixed coding style issues
Date: Tue, 21 Jan 2014 21:29:44 +0100 [thread overview]
Message-ID: <20140121202944.GA4554@fedora.fritz.box> (raw)
In-Reply-To: <20140121200645.GC29615@core.coreip.homeip.net>
On Tue, Jan 21, 2014 at 12:06:45PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 21, 2014 at 08:51:53PM +0100, Robin Schroer wrote:
> > Fixed some coding style issues regarding spaces before semicolons and
> > closing parenthesis.
> >
> > Signed-off-by: Robin Schroer <sulamiification@gmail.com>
> > ---
> > drivers/hid/hid-wacom.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> > index 60c75dc..ebcca0d 100644
> > --- a/drivers/hid/hid-wacom.c
> > +++ b/drivers/hid/hid-wacom.c
> > @@ -77,8 +77,8 @@ static void wacom_scramble(__u8 *image)
> > __u16 mask;
> > __u16 s1;
> > __u16 s2;
> > - __u16 r1 ;
> > - __u16 r2 ;
> > + __u16 r1;
> > + __u16 r2;
> > __u16 r;
> > __u8 buf[256];
> > int i, w, x, y, z;
> > @@ -336,7 +336,7 @@ static void wacom_set_features(struct hid_device *hdev, u8 speed)
> >
> > switch (hdev->product) {
> > case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
> > - rep_data[0] = 0x03 ; rep_data[1] = 0x00;
> > + rep_data[0] = 0x03; rep_data[1] = 0x00;
> > limit = 3;
> > do {
> > ret = hdev->hid_output_raw_report(hdev, rep_data, 2,
> > @@ -404,7 +404,7 @@ static ssize_t wacom_store_speed(struct device *dev,
> > struct hid_device *hdev = container_of(dev, struct hid_device, dev);
> > int new_speed;
> >
> > - if (sscanf(buf, "%1d", &new_speed ) != 1)
> > + if (sscanf(buf, "%1d", &new_speed) != 1)
> > return -EINVAL;
>
> Why doesn't it use kstrtoXXX()?
>
> Thanks.
>
As far as I can see, kstrtoXXX() might be an alternative, but I was just
fixing coding style issues, no need to break anything IMO.
> >
> > if (new_speed == 0 || new_speed == 1) {
> > --
> > 1.8.4.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> --
> Dmitry
--
Robin
next prev parent reply other threads:[~2014-01-21 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 19:51 [PATCH] drivers/hid/wacom: fixed coding style issues Robin Schroer
2014-01-21 20:06 ` Dmitry Torokhov
2014-01-21 20:29 ` Rob Schroer [this message]
2014-01-21 21:18 ` Dmitry Torokhov
2014-01-21 21:25 ` Joe Perches
2014-01-21 22:42 ` Rob Schroer
2014-01-22 6:40 ` Dmitry Torokhov
2014-01-22 14:48 ` Rob Schroer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121202944.GA4554@fedora.fritz.box \
--to=sulamiification@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.