From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 7/7] nfs: page cache invalidation for dio
Date: Wed, 22 Jan 2014 00:24:14 -0800 [thread overview]
Message-ID: <20140122082414.GA12530@infradead.org> (raw)
In-Reply-To: <20140121142159.210ca0b8@tlielax.poochiereds.net>
On Tue, Jan 21, 2014 at 02:21:59PM -0500, Jeff Layton wrote:
> In any case, this helps but it's a little odd. With this patch, you add
> an invalidate_inode_pages2 call prior to doing the DIO. But, you've
> also left in the call to nfs_zap_mapping in the completion codepath.
>
> So now, we shoot down the mapping prior to doing a DIO write, and then
> mark the mapping for invalidation again when the write completes. Was
> that intentional?
>
> It seems a little excessive and might hurt performance in some cases.
> OTOH, if you mix buffered and DIO you're asking for trouble anyway and
> this approach seems to give better cache coherency.
Thile follows the model implemented and documented in
generic_file_direct_write().
next prev parent reply other threads:[~2014-01-22 8:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 16:50 [PATCH 0/7] direct I/O fixes Christoph Hellwig
2013-11-14 16:50 ` [PATCH 1/7] nfs: fix size updates for aio writes Christoph Hellwig
2013-11-14 16:50 ` [PATCH 2/7] nfs: defer inode_dio_done call until size update is done Christoph Hellwig
2013-11-14 16:50 ` [PATCH 3/7] nfs: increment i_dio_count for reads, too Christoph Hellwig
2013-11-14 16:50 ` [PATCH 4/7] nfs: merge nfs_direct_read into nfs_file_direct_read Christoph Hellwig
2013-11-14 16:50 ` [PATCH 5/7] nfs: merge nfs_direct_write into nfs_file_direct_write Christoph Hellwig
2013-11-14 16:50 ` [PATCH 6/7] nfs: take i_mutex during direct I/O reads Christoph Hellwig
2013-11-14 17:00 ` Chuck Lever
2013-11-15 14:29 ` Christoph Hellwig
2013-11-14 20:43 ` Trond Myklebust
2013-11-15 14:32 ` Christoph Hellwig
2013-11-15 15:23 ` Trond Myklebust
2013-11-15 15:25 ` Christoph Hellwig
2013-11-15 15:34 ` Trond Myklebust
2013-11-15 15:37 ` Christoph Hellwig
2013-11-15 16:00 ` Trond Myklebust
2013-11-14 16:50 ` [PATCH 7/7] nfs: page cache invalidation for dio Christoph Hellwig
2013-11-14 18:35 ` Jeff Layton
2013-11-15 14:28 ` Christoph Hellwig
2013-11-15 14:52 ` Jeff Layton
2013-11-15 15:02 ` Christoph Hellwig
2013-11-15 15:33 ` Jeff Layton
2014-01-21 19:21 ` Jeff Layton
2014-01-22 8:24 ` Christoph Hellwig [this message]
2014-01-22 12:04 ` Jeff Layton
2014-01-24 15:50 ` Jeff Layton
2014-01-24 15:52 ` Jeff Layton
2014-01-24 17:11 ` Trond Myklebust
2014-01-24 17:29 ` Jeff Layton
2014-01-24 17:40 ` Trond Myklebust
2014-01-24 18:00 ` Jeff Layton
2014-01-24 18:46 ` Trond Myklebust
2014-01-24 21:21 ` Jeff Layton
2014-01-25 0:39 ` Trond Myklebust
2014-01-25 0:54 ` Jeff Layton
2014-01-25 1:05 ` Trond Myklebust
2014-01-25 1:11 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122082414.GA12530@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.