From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [alsa-devel] [PATCH RFC v2 REPOST 3/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus Date: Wed, 22 Jan 2014 11:19:53 +0100 Message-ID: <20140122111953.238349a5@armhf> References: <20131231132555.GA31886@sirena.org.uk> <52D67099.1040904@ti.com> <20140115165100.3bfab96f@armhf> <52DF8D60.9020505@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <52DF8D60.9020505@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Jyri Sarha Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, "Ujfalusi, Peter" , Mark Brown , bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gV2VkLCAyMiBKYW4gMjAxNCAxMToyMDozMiArMDIwMApKeXJpIFNhcmhhIDxqc2FyaGFAdGku Y29tPiB3cm90ZToKCj4gT24gMDEvMTUvMjAxNCAwNTo1MSBQTSwgSmVhbi1GcmFuY29pcyBNb2lu ZSB3cm90ZToKPiA+IE9uIFdlZCwgMTUgSmFuIDIwMTQgMTM6Mjc6MjEgKzAyMDAKPiA+IEp5cmkg U2FyaGEgPGpzYXJoYUB0aS5jb20+IHdyb3RlOgo+ID4KPiA+PiAgIEZyb20gZHJpdmVyL2dwdS9k cm0vaTJjL3RkYTk5OHhfZHJ2LmMuIFRoZSBkcml2ZXIgY29uZmlndXJlcyBDVFNfTgo+ID4+IHJl Z2lzdGVyIHN0YXRpY2FsbHkgdG8gYSB2YWx1ZSB0aGF0IHdvcmtzIG9ubHkgd2l0aCA0IGJ5dGUg c2FtcGxlcy4KPiA+PiBBY2NvcmRpbmcgdG8gbXkgdGVzdHMgaXQgaXMgcG9zc2libGUgdG8gc3Vw cG9ydCAzIGFuZCAyIGJ5dGUgc2FtcGxlcyB0b28KPiA+PiBieSBjaGFuZ2luZyB0aGUgQ1RTX04g cmVnaXN0ZXIgdmFsdWUsIGJ1dCBJIGFtIG5vdCBzdXJlIGlmIHRoZQo+ID4+IGNvbmZpZ3VyYXRp b24gY2FuIGJlIGNoYW5nZWQgb24gdGhlIGZseS4gTXkgZGF0YSBzaGVldCBvZiB0aGUgbnhwIGNo aXAKPiA+PiBpcyB2ZXJ5IHZhZ3VlIGFib3V0IHRoZSByZWdpc3RlciBkZWZpbml0aW9ucywgYnV0 IEkgc3VwcG9zZSB0aGUgcmVnaXN0ZXIKPiA+PiBjb25maWd1cmVzIHNvbWUgY2xvY2sgZGl2aWRl ciBvbiB0aGUgY2hpcC4gSERNSSBzdXBwb3J0cyBvbmx5IHVwdG8gMjRiaXQKPiA+PiBhdWRpbyBh bmQgdGhlIGRhdGEgc2hlZXQgc3RhdGVzIHRoYXQgYW55IGV4dHJhbmVvdXMgbGVhc3Qgc2lnbmlm aWNhbnQKPiA+PiBiaXRzIGFyZSBpZ25vcmVkLgo+ID4KPiA+IEluIHRoZSB0ZGE5OTh4IGRyaXZl ciwgdGhlIENUU19OIGlzIGF1dG9tYXRpYyAoQUlQX0NOVFJMXzBfQUNSX01BTiBpcwo+ID4gbm90 IHNldCkuCj4gPgo+ID4gVGhlbiwgaW4gbXkgQ3Vib3ggKE1hcnZlbGwgQTUxMCArIHRkYTE5OTg4 KSwgdGhlIDE2LCAyNCBhbmQgMzIgYml0cwo+ID4gZm9ybWF0cyBhcmUgd29ya2luZyB3ZWxsIHdp dGggSTJTIGlucHV0IGF0IGFueSByYXRlLgo+ID4KPiAKPiBDb3VsZCB5b3UgcmVmZXIgdGhlIGtl cm5lbCB2ZXJzaW9uIChtYWluIGxpbmU/KSBhbmQgdGhlIGludm9sdmVkIEFTb0MgCj4gZHJpdmVy cyBzbyBjb3VsZCB0YWtlIEkgYSBsb29rIGlmIHRoZXJlIGlzIHNvbWV0aGluZyBJIGNvdWxkIGRv IGRpZmZlcmVudGx5PwoKQm90aCBkcml2ZXJzIGFyZSBpbiB0aGUga2VybmVsIG1haW4gbGluZS4K ClRoZSBBU29DIGlzIGluIHNvdW5kL3NvYy9raXJrd29vZC8uIGtpcmt3b29kLWkycy5jIGRlZmlu ZXMgdGhlIERBSXMgSTJTCmFuZCBTL1BESUYgb3V0cHV0cy4KCkFzIGJvdGggSTJTIGFuZCBTL1BE SUYgbWF5IGJlIHVzZWQgZm9yIEhETUkgb3V0cHV0IGluIHRoZSBDdWJveCwKSSB3cm90ZSBhIHRk YTk5OHggQ09ERUMgd2hpY2ggZ2V0cyB0aGUgYXVkaW8gcG9ydHMgZnJvbSB0aGUgRFQgYW5kCmR5 bmFtaWNhbGx5IHNldHMgdGhlc2UgcG9ydHMgYW5kIHRoZSBhdWRpbyB0eXBlIChpMnMgLyBzcGRp Zikgb24gYXVkaW8Kc3RyZWFtaW5nIHN0YXJ0LiBJIGhhdmUgbm90IHN1Ym1pdHRlZCB5ZXQgdGhp cyBjb2RlYyBhbmQgdGhlIGFzc29jaWF0ZWQKY2hhbmdlcyBpbiB0ZGE5OTh4LCBiZWNhdXNlIEkg YW0gd2FpdGluZyBmb3IgYSBmaXJzdCBwYXRjaCBzZXJpZXMgb24gdGhlCnRkYTk5OHggdG8gYmUg YXBwbGllZAooaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwv MjAxNC1KYW51YXJ5LzA1MTU1Mi5odG1sKS4KCi0tIApLZW4gYXIgYydoZW50YcOxCXwJICAgICAg KiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYuZnJlZS5m ci8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Wed, 22 Jan 2014 11:19:53 +0100 Subject: [alsa-devel] [PATCH RFC v2 REPOST 3/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus In-Reply-To: <52DF8D60.9020505@ti.com> References: <20131231132555.GA31886@sirena.org.uk> <52D67099.1040904@ti.com> <20140115165100.3bfab96f@armhf> <52DF8D60.9020505@ti.com> Message-ID: <20140122111953.238349a5@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 22 Jan 2014 11:20:32 +0200 Jyri Sarha wrote: > On 01/15/2014 05:51 PM, Jean-Francois Moine wrote: > > On Wed, 15 Jan 2014 13:27:21 +0200 > > Jyri Sarha wrote: > > > >> From driver/gpu/drm/i2c/tda998x_drv.c. The driver configures CTS_N > >> register statically to a value that works only with 4 byte samples. > >> According to my tests it is possible to support 3 and 2 byte samples too > >> by changing the CTS_N register value, but I am not sure if the > >> configuration can be changed on the fly. My data sheet of the nxp chip > >> is very vague about the register definitions, but I suppose the register > >> configures some clock divider on the chip. HDMI supports only upto 24bit > >> audio and the data sheet states that any extraneous least significant > >> bits are ignored. > > > > In the tda998x driver, the CTS_N is automatic (AIP_CNTRL_0_ACR_MAN is > > not set). > > > > Then, in my Cubox (Marvell A510 + tda19988), the 16, 24 and 32 bits > > formats are working well with I2S input at any rate. > > > > Could you refer the kernel version (main line?) and the involved ASoC > drivers so could take I a look if there is something I could do differently? Both drivers are in the kernel main line. The ASoC is in sound/soc/kirkwood/. kirkwood-i2s.c defines the DAIs I2S and S/PDIF outputs. As both I2S and S/PDIF may be used for HDMI output in the Cubox, I wrote a tda998x CODEC which gets the audio ports from the DT and dynamically sets these ports and the audio type (i2s / spdif) on audio streaming start. I have not submitted yet this codec and the associated changes in tda998x, because I am waiting for a first patch series on the tda998x to be applied (http://lists.freedesktop.org/archives/dri-devel/2014-January/051552.html). -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/