Re: [BUG] at drivers/md/raid5.c:291! kernel 3.13-rc8

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Mon, 20 Jan 2014 19:27:18 +0100 Ian Kumlien <ian.kumlien@gmail.com> wrote:

> On mån, 2014-01-20 at 14:37 +1100, NeilBrown wrote:
> > 
> > Thanks - that extra info is quite useful.  Knowing that nothing else unusual
> > is happening can be quite valuable (and I don't like to assume).
> > 
> > I haven't found anything that would clearly cause your crash, but I have
> > found something that looks wrong and conceivably could.
> > 
> > Could you please try this patch on top of what you are currently using?  By
> > the look of it you get a crash at least every day, often more often.  So if
> > this produces a day with no crashes, that would be promising.
> > 
> > The important aspect of the patch is that it moves the "atomic_inc" of
> > "sh->count" back under the protection of ->device_lock in the case when some
> > other thread might be using the same 'sh'.
> 
> I have been unable to trip this up, so this was it!
> 
> Tested-by: Ian Kumlien <ian.kumlien@gmail.com>
> 
> I hope this hits stable ASAP ;)

I've push it out into my for-next branch.
I'll probably send a pull request to Linus tomorrow.
It has some chance of getting into a -stable branch next week (though I'm not
really sure of the schedule).

Thanks again for testing and reporting!

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]